Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not use program data in Beats MSI installers #238

Merged
merged 3 commits into from
Feb 8, 2024

Conversation

cmacknz
Copy link
Member

@cmacknz cmacknz commented Feb 8, 2024

The same as #234 but the branch is in this repository instead of my fork so CI will actually run.

Store configuration, runtime, and log data in ProgramFiles.

This is a follow up from #209

@cmacknz cmacknz self-assigned this Feb 8, 2024
@cmacknz cmacknz requested a review from a team as a code owner February 8, 2024 02:41
@cmacknz
Copy link
Member Author

cmacknz commented Feb 8, 2024

Now that CI works I've tested this. This change adjusts the paths in the beat (e.g. filebeat) command that is automatically added to the path by the MSI installer to point to the location where we have actually installed the files.

This is just a bug fix for #209 where the paths are now wrong in this command helper.

The only caveat here is for people who may be starting Filebeat through this filebeat helper command, then the location of the registry has moved which causes data duplication. I don't think this is breaking because the MSI installs Filebeat as a service and #209 already changed those paths.

@cmacknz cmacknz merged commit 0f861f5 into main Feb 8, 2024
3 checks passed
@cmacknz cmacknz deleted the do-not-use-program-data branch February 8, 2024 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants