Aiohttp fixed bug with HEAD requests and connection reuse #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pquentin
added a commit
to pquentin/elasticsearch-py
that referenced
this pull request
Nov 4, 2022
This backports the following pull requests to the 7.17 branch to make it easier for Rally to upgrade to elasticsearch-py 8.x: * elastic/elastic-transport-python#55 * elastic/elastic-transport-python#58
pquentin
added a commit
to pquentin/elasticsearch-py
that referenced
this pull request
Nov 4, 2022
In older versions of aiohttp, HEAD requests don't mark the connection as not reusable, which is why GET was used instead. But this means `indices.exists` becomes `indices.get` which can be prohibitively slow on indices with large mappings, so we want to use `HEAD` for aiohttp versions that don't have this bug. This backports the following pull requests to the 7.17 branch to make it easier for Rally to upgrade to elasticsearch-py 8.x: * elastic/elastic-transport-python#55 * elastic/elastic-transport-python#58
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since 3.7.0 (October 2020) the bug in aiohttp has been fixed where HEAD requests don't mark the connection as not reusable.