Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for mocking library #1545

Merged
merged 3 commits into from
Aug 30, 2021
Merged

Add test for mocking library #1545

merged 3 commits into from
Aug 30, 2021

Conversation

delvedor
Copy link
Member

@delvedor delvedor commented Aug 30, 2021

As titled, this should help to catch errors before release.

Wait for elastic/elasticsearch-js-mock#20.

@delvedor delvedor merged commit b67d42c into main Aug 30, 2021
@delvedor delvedor deleted the test-mock branch August 30, 2021 13:36
@github-actions
Copy link
Contributor

The backport to 7.x failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-7.x 7.x
# Navigate to the new working tree
cd .worktrees/backport-7.x
# Create a new branch
git switch --create backport-1545-to-7.x
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick --mainline 1 b67d42cb5ff7a39a1836d176266ac32af9e72f07
# Push it to GitHub
git push --set-upstream origin backport-1545-to-7.x
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-7.x

Then, create a pull request where the base branch is 7.x and the compare/head branch is backport-1545-to-7.x.

delvedor added a commit that referenced this pull request Aug 30, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant