Build: Switch mapper attachments to gradle #184
Conversation
This change switches the plugin to use gradle as the build system, and updates the master branch to track elasticsearch master.
| exclude group: 'edu.ucar', module: 'netcdf4' | ||
| exclude group: 'com.uwyn', module: 'jhighlight' | ||
| // ES core already has these | ||
| exclude group: 'org.aw2.asm', module: 'asm-debug-all' |
There was a problem hiding this comment.
I just copied what was in the pom. I will remove.
| } | ||
|
|
||
| project.group = 'org.elasticsearch' | ||
| project.version = ElasticsearchProperties.version |
There was a problem hiding this comment.
Might be wrong but I think this should be now 4.0.0-SNAPHOT
There was a problem hiding this comment.
Hrm, I thought we released 2.0 plugins under a different groupId so that we could get the plugin versions in sync with elasticsearch version?
There was a problem hiding this comment.
So we need to change the groupId here?
But that would mean a lot other changes. For now, I'd update the version.
There was a problem hiding this comment.
Oops, that is just the wrong groupId from copy/pasting! But I'm confused on why we would change the version. Did we or did we not release plugins under org.elasticsearch.plugin all with version 2.0.0?
There was a problem hiding this comment.
Yes we did. I don't have an opinion. We can do one or the other.
If we keep old groupId, then we can release this plugin more often (not sure it makes sense though).
If we use the new groupId (ES version), we can only release when elasticsearch releases.
The easier thing to do though is to move this plugin under elasticsearch repo.
There was a problem hiding this comment.
This is master. Can we just get the build working again (this PR) as a start?
|
We also need to change https://github.com/elastic/elasticsearch-mapper-attachments/blob/master/dev-tools/release.py Might be done in another PR though. |
Yeah, let's do that in a follow up. This is just to get the build working again. Lots needs to be changed about the release. |
Build: Switch mapper attachments to gradle
This change switches the plugin to use gradle as the build system, and
updates the master branch to track elasticsearch master.