Ml calendar apis #3569
Merged
Ml calendar apis #3569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…implemented and tested
|
@codebrain mind retargetting this against |
|
Changed base to 6.6 |
russcam
approved these changes
Mar 5, 2019
| public partial interface IDeleteCalendarJobResponse : IResponse | ||
| { | ||
| [JsonProperty("calendar_id")] | ||
| Id CalendarId { get; } |
There was a problem hiding this comment.
Do we typically return Nest types like Id on responses, or leave them as primitive types e.g. string?
There was a problem hiding this comment.
Good catch, will change to string - I think that is better and will likely play nicer with a different serialiser.
| public partial interface IElasticClient | ||
| { | ||
| /// <summary> | ||
| /// Retrieves configuration for machine learning jobs. |
There was a problem hiding this comment.
Retrieves calendar configuration information for machine learning jobs?
| public partial interface IElasticClient | ||
| { | ||
| /// <summary> | ||
| /// Instantiates a machine learning calendar. |
There was a problem hiding this comment.
Maybe Creates might be better here?
|
Ported to |
|
Subsequent commit made to address other types in response objects, not merged as part of this commit. This was also ported to |
russcam
pushed a commit
that referenced
this pull request
Mar 20, 2019
russcam
pushed a commit
that referenced
this pull request
Mar 21, 2019
russcam
pushed a commit
that referenced
this pull request
Apr 2, 2019
(cherry picked from commit 2f040c4)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implementation of the
6.4.0ML calendar APIs - see here: #3552Requires port to
master