Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Pause/Resume Auto Follower APIs #4273

Merged
merged 5 commits into from
Dec 18, 2019
Merged

Add Pause/Resume Auto Follower APIs #4273

merged 5 commits into from
Dec 18, 2019

Conversation

codebrain
Copy link
Contributor

@Mpdreamz Mpdreamz mentioned this pull request Dec 16, 2019
Closed
24 tasks
russcam
russcam suggested changes Dec 17, 2019
View reviewed changes
Copy link
Contributor

@russcam russcam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing integration tests - could add steps to CrossClusterReplicationAutoFollowTests?

@codebrain
Copy link
Contributor Author

Missing integration tests - could add steps to CrossClusterReplicationAutoFollowTests?

The only issue is that the test suite is marked with a BlockedByIssue attribute, so this suite doesn't run. I can add some placeholder tests in?

@Mpdreamz
Copy link
Member

The BlockedByIssue does not seem relevant anymore

@codebrain
Copy link
Contributor Author

OK, the issue with the integration tests is "could not determine the license type for cluster [remote-cluster]".

This fails as the remote cluster is not actually running, but is provided as settings only (

elasticsearch-net/src/Tests/Tests.Core/ManagedElasticsearch/NodeSeeders/DefaultSeeder.cs

Line 96 in 27f44ed

clusterConfiguration += new RemoteClusterConfiguration
).

Will open an issue for this.

@codebrain
Copy link
Contributor Author

Opened: #4284

@codebrain codebrain merged commit 1c07db6 into 7.x Dec 18, 2019
codebrain added a commit that referenced this pull request Dec 18, 2019
@codebrain
Add Pause/Resume Auto Follower APIs #4273
04fa7ce
@codebrain
Copy link
Contributor Author

Ported to master

@codebrain codebrain deleted the feature/7.5/pause-resume-apis branch December 18, 2019 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@russcam russcam russcam requested changes

Assignees
No one assigned
Labels
backport main
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@codebrain @Mpdreamz @russcam