Correct calculation of avg value to avoid overflow

elastic · Nov 15, 2019 · d147e0f · d147e0f
1 parent f6516aa
commit d147e0f
Showing 1 changed file with 1 addition and 1 deletion.
diff --git a/server/src/main/java/org/elasticsearch/search/query/QueryPhase.java b/server/src/main/java/org/elasticsearch/search/query/QueryPhase.java
@@ -584,7 +584,7 @@ static long estimateMedianValue(PointValues pointValues) throws IOException {
         long minValue = LongPoint.decodeDimension(pointValues.getMinPackedValue(), 0);
         long maxValue = LongPoint.decodeDimension(pointValues.getMaxPackedValue(), 0);
         while (minValue < maxValue) {
-            long avgValue = Math.floorDiv(minValue + maxValue, 2);
+            long avgValue = Math.floorDiv(minValue, 2) + Math.floorDiv(maxValue, 2); // to avoid overflow first divide each value by 2
             long countLeft = estimatePointCount(pointValues, minValue, avgValue);
             long countRight = estimatePointCount(pointValues, avgValue + 1, maxValue);
             if (countLeft >= countRight) {