Terms order aggregation name cannot contain a period

[niemyjski]

I'm running on 1.7.5 and the following works:

  "aggs": {
    "terms": {
      "terms": {
        "field": "stack_id",
        "size": 21,
        "order": {
          "distinct_user_raw": "desc"
        }
      },
      "aggs": {
        "distinct_user_raw": {
          "cardinality": {
            "field": "user.raw",
            "precision_threshold": 100
          }
        }
      }
    }
  }

however the following throws an error:

  "aggs": {
    "terms": {
      "terms": {
        "field": "stack_id",
        "size": 21,
        "order": {
          "distinct_user.raw": "desc"
        }
      },
      "aggs": {
        "distinct_user.raw": {
          "cardinality": {
            "field": "user.raw",
            "precision_threshold": 100
          }
        }
      }
    }
  }

with the error:

{
   "error": "SearchPhaseExecutionException[Failed to execute phase [query], all shards failed; shardFailures {[vsKZW_avSS6E_Ci72eNoFg][events-v1-201604][0]: AggregationExecutionException[Invalid term-aggregator order path [distinct_user.raw]. Unknown aggregation [distinct_user]]}{[vsKZW_avSS6E_Ci72eNoFg][events-v1-201604][1]: AggregationExecutionException[Invalid term-aggregator order path [distinct_user.raw]. Unknown aggregation [distinct_user]]}{[vsKZW_avSS6E_Ci72eNoFg][events-v1-201604][2]: AggregationExecutionException[Invalid term-aggregator order path [distinct_user.raw]. Unknown aggregation [distinct_user]]}{[vsKZW_avSS6E_Ci72eNoFg][events-v1-201604][3]: AggregationExecutionException[Invalid term-aggregator order path [distinct_user.raw]. Unknown aggregation [distinct_user]]}{[vsKZW_avSS6E_Ci72eNoFg][events-v1-201604][4]: AggregationExecutionException[Invalid term-aggregator order path [distinct_user.raw]. Unknown aggregation [distinct_user]]}{[vsKZW_avSS6E_Ci72eNoFg][events-v1-201604][5]: AggregationExecutionException[Invalid term-aggregator order path [distinct_user.raw]. Unknown aggregation [distinct_user]]}{[vsKZW_avSS6E_Ci72eNoFg][events-v1-201604][6]: AggregationExecutionException[Invalid term-aggregator order path [distinct_user.raw]. Unknown aggregation [distinct_user]]}{[vsKZW_avSS6E_Ci72eNoFg][events-v1-201604][7]: AggregationExecutionException[Invalid term-aggregator order path [distinct_user.raw]. Unknown aggregation [distinct_user]]}{[vsKZW_avSS6E_Ci72eNoFg][events-v1-201604][8]: AggregationExecutionException[Invalid term-aggregator order path [distinct_user.raw]. Unknown aggregation [distinct_user]]}{[vsKZW_avSS6E_Ci72eNoFg][events-v1-201604][9]: AggregationExecutionException[Invalid term-aggregator order path [distinct_user.raw]. Unknown aggregation [distinct_user]]}]",
   "status": 500
}

Please note that if I remove the order part it works.

[clintongormley]

Yes. Don't do that :)

I tried out the bucket path syntax (eg using [bar.baz]._count) but that isn't supported here. Perhaps we should.

[niemyjski]

The fact that you can have aggregations with periods but not sort by it seems like a bug. On a side note I changed my code to remove the periods. But it should be all or nothing (you can sort by it, or aggregation names should be allowed to have a .)

[jpountz]

Related to #9059.

[markharwood]

Revisiting after some time - still fails on master.

cc @elastic/es-search-aggs

[markharwood]

Related issue concerning dots in agg names: #19040

[polyfractal]

This is, tragically, still an issue. It's not blocked on anything that I'm aware of though, so removing the stalled.

[elasticsearchmachine]

Pinging @elastic/es-analytics-geo (Team:Analytics)

[wchaparro]

Closing as not planned.