Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve documentation around which units are and are not allowed in the date_histogram #29410

Closed
colings86 opened this issue Apr 6, 2018 · 2 comments
Closed

Improve documentation around which units are and are not allowed in the date_histogram #29410

colings86 opened this issue Apr 6, 2018 · 2 comments
Labels
:Analytics/Aggregations Aggregations >docs General docs changes help wanted adoptme

Comments

@colings86
Copy link
Contributor

Spilt out from #28432.

We should improve the documentation for the date_histogram aggregation to make it clear which units are allowed in singular form (e.g. "1d") and multiple form (e.g. "2d") and the difference in behaviour between these two (namely that the former is a calendar interval and the latter is a fixed duration in milliseconds.

This is far from an ideal API and I will update this issue with a link to another issue I'll open about improving this situation

@elastic/es-search-aggs
@colings86 colings86 added >docs General docs changes help wanted adoptme :Analytics/Aggregations Aggregations labels Apr 6, 2018
@colings86
Copy link
Contributor Author

The above mentioned issue is: #29411

@colings86 colings86 mentioned this issue Apr 6, 2018
Closed
Sue-Gallagher added a commit that referenced this issue Jun 27, 2018
@Sue-Gallagher
[DOCS] Add info on calendar v fixed interval. Closes #29410
fe0131f
@Sue-Gallagher Sue-Gallagher self-assigned this Jun 27, 2018
Sue-Gallagher added a commit to Sue-Gallagher/elasticsearch that referenced this issue Jul 16, 2018
@Sue-Gallagher
[DOCS] Add info on calendar v fixed interval. Closes elastic#29410
f0ebcec
Sue-Gallagher added a commit to Sue-Gallagher/elasticsearch that referenced this issue Jul 16, 2018
@Sue-Gallagher
[DOCS] Add info on calendar v fixed interval. Closes elastic#29410
402bdaa
Sue-Gallagher added a commit to Sue-Gallagher/elasticsearch that referenced this issue Jul 16, 2018
@Sue-Gallagher
[DOCS] Add info on calendar v fixed interval. Closes elastic#29410
2ffd037
Sue-Gallagher added a commit to Sue-Gallagher/elasticsearch that referenced this issue Jul 16, 2018
@Sue-Gallagher
[DOCS] Add info on calendar v fixed interval. Closes elastic#29410
e4c99b3 
q!
Sue-Gallagher added a commit to Sue-Gallagher/elasticsearch that referenced this issue Jul 16, 2018
@Sue-Gallagher
[DOCS] Add info on calendar v fixed interval. Closes elastic#29410
62a3ebe 
q!

q
Sue-Gallagher added a commit to Sue-Gallagher/elasticsearch that referenced this issue Jul 16, 2018
@Sue-Gallagher
[DOCS] Add info on calendar v fixed interval. Closes elastic#29410
41af6ea
Sue-Gallagher added a commit to Sue-Gallagher/elasticsearch that referenced this issue Jul 16, 2018
@Sue-Gallagher
[DOCS] Add info on calendar v fixed interval. Closes elastic#29410
f71f2a0
Sue-Gallagher added a commit to Sue-Gallagher/elasticsearch that referenced this issue Jul 16, 2018
@Sue-Gallagher
[DOCS] Add info on calendar v fixed interval. Closes elastic#29410
dc77d91
Sue-Gallagher added a commit to Sue-Gallagher/elasticsearch that referenced this issue Jul 16, 2018
@Sue-Gallagher
[DOCS] Add info on calendar v fixed interval. Closes elastic#29410
929355a
@polyfractal
Copy link
Contributor

Closed by #31638

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Analytics/Aggregations Aggregations >docs General docs changes help wanted adoptme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@colings86 @polyfractal @Sue-Gallagher