Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] RollupIT#testBig fails #30232

Closed
dnhatn opened this issue Apr 28, 2018 · 2 comments
Closed

[CI] RollupIT#testBig fails #30232

dnhatn opened this issue Apr 28, 2018 · 2 comments
Assignees
@polyfractal
Labels
:StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data >test-failure Triaged test failures from CI

Comments

@dnhatn
Copy link
Member

dnhatn commented Apr 28, 2018

I can reproduce this locally.

./gradlew :x-pack:plugin:rollup:internalClusterTest \
-Dtests.seed=38E445F745E9BA6E \
-Dtests.class=org.elasticsearch.xpack.rollup.RollupIT \
-Dtests.method="testBig" \
-Dtests.security.manager=true \
-Dtests.jvms=8 \
-Dtests.locale=luy \
-Dtests.timezone=Pacific/Apia

Assertion error

FAILURE 7.99s | RollupIT.testBig <<< FAILURES!
   > Throwable #1: java.lang.AssertionError: 
   > Expected: <89L>
   >      but: was <88L>
   >    at __randomizedtesting.SeedInfo.seed([38E445F745E9BA6E:37DA9EAD70777305]:0)
   >    at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
   >    at org.elasticsearch.xpack.rollup.RollupIT.testBig(RollupIT.java:429)
   >    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
   >    at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
   >    at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
   >    at java.base/java.lang.reflect.Method.invoke(Method.java:564)
   >    at java.base/java.lang.Thread.run(Thread.java:844)
@dnhatn dnhatn added >test Issues or PRs that are addressing/adding tests :StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data labels Apr 28, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@sohaibiftikhar sohaibiftikhar mentioned this issue May 3, 2018
Closed
@polyfractal
Copy link
Contributor

I haven't been able to replicate this locally yet, but it failed again three days ago with:

./gradlew :x-pack:plugin:rollup:internalClusterTest \
  -Dtests.seed=4C51DCAD1A755E3F \
  -Dtests.class=org.elasticsearch.xpack.rollup.RollupIT \
  -Dtests.method="testBig" \
  -Dtests.security.manager=true \
  -Dtests.locale=uk-UA \
  -Dtests.timezone=Africa/Libreville

Going to work through the test and see if there's something obviously missing, or where additional logging could be added.

@polyfractal polyfractal added >test-failure Triaged test failures from CI and removed >test Issues or PRs that are addressing/adding tests labels May 9, 2018
@polyfractal polyfractal mentioned this issue Jun 14, 2018
Closed
polyfractal added a commit to polyfractal/elasticsearch that referenced this issue Jul 11, 2018
@polyfractal
[Rollup] Replace RollupIT with a ESRestTestCase version
5e4752a 
The old RollupIT was a node IT, an flaky for a number of reasons.
This new version is an ESRestTestCase and should be a little more robust.

This was added to the multi-node QA tests as that seemed like the most
appropriate location.  It didn't seem necessary to create a whole new
QA module.

Note: The only test that was ported was the "Big" test for validating
a larger dataset.  The rest of the tests are represented in existing
yaml tests.

Closes elastic#31258
Closes elastic#30232
Related to elastic#30290
@polyfractal polyfractal mentioned this issue Jul 11, 2018
Merged
@vladimirdolzhenko vladimirdolzhenko mentioned this issue Jul 13, 2018
Closed
polyfractal added a commit that referenced this issue Jul 16, 2018
@polyfractal
[Rollup] Replace RollupIT with a ESRestTestCase version (#31977)
59191b4 
The old RollupIT was a node IT, an flaky for a number of reasons.
This new version is an ESRestTestCase and should be a little more robust.

This was added to the multi-node QA tests as that seemed like the most
appropriate location.  It didn't seem necessary to create a whole new
QA module.

Note: The only test that was ported was the "Big" test for validating
a larger dataset.  The rest of the tests are represented in existing
yaml tests.

Closes #31258
Closes #30232
Related to #30290
polyfractal added a commit that referenced this issue Jul 16, 2018
@polyfractal
[Rollup] Replace RollupIT with a ESRestTestCase version (#31977)
69af822 
The old RollupIT was a node IT, an flaky for a number of reasons.
This new version is an ESRestTestCase and should be a little more robust.

This was added to the multi-node QA tests as that seemed like the most
appropriate location.  It didn't seem necessary to create a whole new
QA module.

Note: The only test that was ported was the "Big" test for validating
a larger dataset.  The rest of the tests are represented in existing
yaml tests.

Closes #31258
Closes #30232
Related to #30290
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@polyfractal polyfractal

Labels
:StorageEngine/Rollup Turn fine-grained time-based data into coarser-grained data >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@polyfractal @dnhatn @elasticmachine