Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CI] watcher.t.i.ExecutionVarsIntegrationTests & WebhookIntegrationTests #30381

Closed
costin opened this issue May 4, 2018 · 1 comment · Fixed by #30403
Closed

[CI] watcher.t.i.ExecutionVarsIntegrationTests & WebhookIntegrationTests #30381

costin opened this issue May 4, 2018 · 1 comment · Fixed by #30403
Labels
:Data Management/Watcher >test-failure Triaged test failures from CI

Comments

@costin
Copy link
Member

costin commented May 4, 2018 

08:34:34 Tests with failures:
08:34:34   - org.elasticsearch.xpack.watcher.test.integration.ExecutionVarsIntegrationTests.testVars
08:34:34   - org.elasticsearch.xpack.watcher.actions.webhook.WebhookIntegrationTests.testWebhook

fails in
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-unix-compatibility/os=ubuntu&&virtual/2400/console
https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+master+multijob-windows-compatibility/1598/console

Reproducible with:

REPRODUCE WITH: ./gradlew :x-pack:plugin:watcher:test -Dtests.seed=80E2F7169B353965 -Dtests.class=org.elasticsearch.xpack.watcher.test.integration.ExecutionVarsIntegrationTests -Dtests.method="testVars" -Dtests.security.manager=true -Dtests.locale=ro-RO -Dtests.timezone=Canada/Saskatchewan

REPRODUCE WITH: ./gradlew :x-pack:plugin:watcher:test -Dtests.seed=80E2F7169B353965 -Dtests.class=org.elasticsearch.xpack.watcher.actions.webhook.WebhookIntegrationTests -Dtests.method="testWebhook" -Dtests.security.manager=true -Dtests.locale=da-DK -Dtests.timezone=Cuba

or

gradlew :x-pack:plugin:watcher:test -Dtests.seed=27F9E9764F12D583 -Dtests.class=org.elasticsearch.xpack.watcher.test.integration.ExecutionVarsIntegrationTests -Dtests.method="testVars" -Dtests.security.manager=true -Dtests.locale=ru-RU -Dtests.timezone=America/Caracas

REPRODUCE WITH: gradlew :x-pack:plugin:watcher:test -Dtests.seed=27F9E9764F12D583 -Dtests.class=org.elasticsearch.xpack.watcher.actions.webhook.WebhookIntegrationTests -Dtests.method="testWebhook" -Dtests.security.manager=true -Dtests.locale=es-HN -Dtests.timezone=Asia/Bangkok
@costin costin added >test Issues or PRs that are addressing/adding tests :Data Management/Watcher labels May 4, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@jasontedor jasontedor added >test-failure Triaged test failures from CI and removed >test Issues or PRs that are addressing/adding tests labels May 4, 2018
spinscale added a commit to spinscale/elasticsearch that referenced this issue May 4, 2018
@spinscale
Watcher: Mark watcher as started only after loading watches
ab75984 
Starting watcher should wait for the watches to be started before
marking the status as started.

Also, reloading watcher could set the execution service to paused. This could
lead to watches not being executed, when run in tests. This fix does not
change the paused flag in the execution service, just clears out the
current queue and executions.

Some tests were affected by this because after putting a watch, the
execution service was still marked as paused, so that the manual
execution with the ScheduleEngineTriggerMock did not work.

Closes elastic#30381
@spinscale spinscale mentioned this issue May 4, 2018
Merged
spinscale added a commit that referenced this issue May 7, 2018
@spinscale
Watcher: Mark watcher as started only after loading watches (#30403)
71ebed6 
Starting watcher should wait for the watcher to be started before
marking the status as started, which is now done via a callback.

Also, reloading watcher could set the execution service to paused. This could
lead to watches not being executed, when run in tests. This fix does not
change the paused flag in the execution service, just clears out the
current queue and executions.

Closes #30381
spinscale added a commit that referenced this issue May 7, 2018
@spinscale
Watcher: Mark watcher as started only after loading watches (#30403)
38bf2bd 
Starting watcher should wait for the watcher to be started before
marking the status as started, which is now done via a callback.

Also, reloading watcher could set the execution service to paused. This could
lead to watches not being executed, when run in tests. This fix does not
change the paused flag in the execution service, just clears out the
current queue and executions.

Closes #30381
colings86 pushed a commit that referenced this issue May 8, 2018
@spinscale @colings86
Watcher: Mark watcher as started only after loading watches (#30403)
51418fc 
Starting watcher should wait for the watcher to be started before
marking the status as started, which is now done via a callback.

Also, reloading watcher could set the execution service to paused. This could
lead to watches not being executed, when run in tests. This fix does not
change the paused flag in the execution service, just clears out the
current queue and executions.

Closes #30381
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Data Management/Watcher >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Watcher: Mark watcher as started only after loading watches spinscale/elasticsearch
3 participants
@costin @jasontedor @elasticmachine