Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SQL: Align class packages in sql-proto and shared-proto projects #31593

Closed
costin opened this issue Jun 26, 2018 · 3 comments
Closed

SQL: Align class packages in sql-proto and shared-proto projects #31593

costin opened this issue Jun 26, 2018 · 3 comments
Assignees

Comments

@costin
Copy link
Member

costin commented Jun 26, 2018

Looks like a left-over from the various class movements:

  1. the package name of the sql-proto project is sql.plugin. This is incorrect and misleading since that's the package of the server. It should be changed to something more appropriate like sql.proto or (to avoid a cycle with 2 below) `sql.proto.action.

  2. the package name of the shared-proto project is sql.proto. Due to 1 above, it should be sql.proto.shared or (since that creates a cycle between proto.shared and proto) to sql.shared.proto or sql.proto.common .

That is, the package name should properly convey the project name and the hierarchy (sql-proto depends on shared-proto not vice versa) without splitting an existing package name.

@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-search-aggs

@imotov imotov self-assigned this Jun 27, 2018
@imotov
Copy link
Contributor

imotov commented Jun 27, 2018

I think we can kill the word shared from the project names and package names. Basically we can

  1. rename project sql-proto-> sql-action,
  2. rename package sql.plugin to sql.action (while moving CliFormatter to sql.client.common)
  3. rename project sql-shared-client -> sql-client
  4. rename package sql.shard.client to sql.client
  5. rename sql-shared-proto -> sql-proto (leave sql.proto there as is)

@costin
Copy link
Member Author

costin commented Jun 27, 2018

+1
I would move CliFormatter either to sql.cli.common (since it's not used in other clients) or just leave it in sql.action for the time being.

imotov added a commit to imotov/elasticsearch that referenced this issue Jun 27, 2018
- renames project sql-proto-> sql-action,
- renames package sql.plugin to sql.action
- renames project sql-shared-client -> sql-client
- renames package sql.shard.client to sql.client
- renames project sql-shared-proto -> sql-proto

Closes elastic#31593
imotov added a commit that referenced this issue Jun 28, 2018
#31622)

- renames project `sql-proto` to `sql-action`,
- renames package `sql.plugin` to `sql.action`
- renames project `sql-shared-client` to `sql-client`
- renames package `sql.shard.client` to `sql.client`
- renames project `sql-shared-proto` to `sql-proto`

Closes #31593
imotov added a commit that referenced this issue Jun 28, 2018
#31622)

- renames project `sql-proto` to `sql-action`,
- renames package `sql.plugin` to `sql.action`
- renames project `sql-shared-client` to `sql-client`
- renames package `sql.shard.client` to `sql.client`
- renames project `sql-shared-proto` to `sql-proto`

Closes #31593
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants