Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ML] [CI] DetectionRulesIT.testCondition failure #31916

Closed
davidkyle opened this issue Jul 10, 2018 · 1 comment · Fixed by #31957
Closed

[ML] [CI] DetectionRulesIT.testCondition failure #31916

davidkyle opened this issue Jul 10, 2018 · 1 comment · Fixed by #31957
Assignees
@dimitris-athanasiou
Labels
:ml Machine learning >test-failure Triaged test failures from CI v6.4.0 v7.0.0-beta1

Comments

@davidkyle
Copy link
Member

This test fails with the error:

Expected: "low"
     but: was "high"
	at __randomizedtesting.SeedInfo.seed([C579EF26625EB1F4:9CC01CBE66771FFC]:0)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:20)
	at org.junit.Assert.assertThat(Assert.java:956)
	at org.junit.Assert.assertThat(Assert.java:923)
	at org.elasticsearch.xpack.ml.integration.DetectionRulesIT.testCondition(DetectionRulesIT.java:120)

It appears the updated rules are not being picked up.

Reproduces fairly frequently for me ~ every other time:

./gradlew :x-pack:qa:ml-native-multi-node-tests:integTestRunner \
  -Dtests.seed=C579EF26625EB1F4 \
  -Dtests.class=org.elasticsearch.xpack.ml.integration.DetectionRulesIT \
  -Dtests.method="testCondition" \
  -Dtests.security.manager=true \
  -Dtests.locale=pt \
  -Dtests.timezone=Etc/GMT-7
@davidkyle davidkyle added >test-failure Triaged test failures from CI v7.0.0 :ml Machine learning v6.4.0 labels Jul 10, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@dimitris-athanasiou dimitris-athanasiou self-assigned this Jul 11, 2018
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this issue Jul 11, 2018
@dimitris-athanasiou
[ML] Ensure immutability of MlMetadata
319f5af 
The test failure in elastic#31916 revealed that updating
rules on a job was modifying the detectors list
in-place. That meant the old cluster state and the
updated cluster state had no difference and thus the
change was not propagated to non-master nodes.

This commit fixes that and also reviews all of ML
metadata in order to ensure immutability.

Closes elastic#31916
@dimitris-athanasiou dimitris-athanasiou mentioned this issue Jul 11, 2018
Merged
dimitris-athanasiou added a commit that referenced this issue Jul 12, 2018
@dimitris-athanasiou
[ML] Ensure immutability of MlMetadata (#31957)
2cfe703 
The test failure in #31916 revealed that updating
rules on a job was modifying the detectors list
in-place. That meant the old cluster state and the
updated cluster state had no difference and thus the
change was not propagated to non-master nodes.

This commit fixes that and also reviews all of ML
metadata in order to ensure immutability.

Closes #31916
dimitris-athanasiou added a commit to dimitris-athanasiou/elasticsearch that referenced this issue Jul 12, 2018
@dimitris-athanasiou
[6.x][ML] Ensure immutability of MlMetadata (elastic#31957)
e2c95ae 
The test failure in elastic#31916 revealed that updating
rules on a job was modifying the detectors list
in-place. That meant the old cluster state and the
updated cluster state had no difference and thus the
change was not propagated to non-master nodes.

This commit fixes that and also reviews all of ML
metadata in order to ensure immutability.

Closes elastic#31916
dimitris-athanasiou added a commit that referenced this issue Jul 12, 2018
@dimitris-athanasiou
[6.x][ML] Ensure immutability of MlMetadata (#31994)
02fa0d4 
The test failure in #31916 revealed that updating
rules on a job was modifying the detectors list
in-place. That meant the old cluster state and the
updated cluster state had no difference and thus the
change was not propagated to non-master nodes.

This commit fixes that and also reviews all of ML
metadata in order to ensure immutability.

Closes #31916
@jimczi jimczi added v7.0.0-beta1 and removed v7.0.0 labels Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dimitris-athanasiou dimitris-athanasiou

Labels
:ml Machine learning >test-failure Triaged test failures from CI v6.4.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[ML] Ensure immutability of MlMetadata dimitris-athanasiou/elasticsearch
4 participants
@davidkyle @dimitris-athanasiou @elasticmachine @jimczi