intervals queries fail percolator term extraction
#45639
Labels
:Search Relevance/Percolator
Reverse search: find queries that match a document
Team:Search Relevance
Meta label for the Search Relevance team in Elasticsearch
Comments
jimczi
added
the
:Search Relevance/Percolator
|
Pinging @elastic/es-search |
|
@romseygeek can you take a look ? |
romseygeek
added a commit
that referenced
this issue
Nov 18, 2019
Lucene now allows us to explore the structure of a query using QueryVisitors, delegating the knowledge of how to recurse through and collect terms to the query implementations themselves. The percolator currently has a home-grown external version of this API to construct sets of matching terms that must be present in a document in order for it to possibly match the query. This commit removes the home-grown implementation in favour of one using QueryVisitor. This has the added benefit of making interval queries available for percolator pre-filtering. Due to a bug in multi-term intervals (LUCENE-9050) it also includes a clone of some of the lucene intervals logic, that can be removed once upstream has been fixed. Closes #45639
romseygeek
added a commit
that referenced
this issue
Nov 20, 2019
Lucene now allows us to explore the structure of a query using QueryVisitors, delegating the knowledge of how to recurse through and collect terms to the query implementations themselves. The percolator currently has a home-grown external version of this API to construct sets of matching terms that must be present in a document in order for it to possibly match the query. This commit removes the home-grown implementation in favour of one using QueryVisitor. This has the added benefit of making interval queries available for percolator pre-filtering. Due to a bug in multi-term intervals (LUCENE-9050) it also includes a clone of some of the lucene intervals logic, that can be removed once upstream has been fixed. Closes #45639
This was referenced Feb 3, 2020
javanna
added
the
Team:Search Relevance
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Elasticsearch version (
bin/elasticsearch --version): 7.2.0 (deb)Plugins installed: [ discovery-ec2, analysis-icu ]
JVM version (
java -version): 1.8.0_131OS version (
uname -aif on a Unix-like system): Linux 4.4.0-1085-aws #96-Ubuntu SMP Tue Jun 11 09:08:32 UTC 2019 x86_64 x86_64 x86_64 GNU/LinuxDescription of the problem including expected versus actual behavior:
Percolator queries that contain an
intervalsclause fail term extraction.Expected: Intervals queries will be supported by percolator term extraction and pre-filtering.
Actual: Intervals queries fail term extraction and are always considered for percolation.
Steps to reproduce:
percolatorfield (name doesn't matter, but I used "query")intervalsclause{ "term": { "query.extraction_result": "failed" } }The text was updated successfully, but these errors were encountered: