Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

policy_id type in Get Snapshot Lifecycle API REST spec should be list #47765

Closed
russcam opened this issue Oct 9, 2019 · 1 comment · Fixed by #47766
Closed

policy_id type in Get Snapshot Lifecycle API REST spec should be list #47765

russcam opened this issue Oct 9, 2019 · 1 comment · Fixed by #47766
Labels
>bug :Core/Infra/REST API REST infrastructure and utilities

Comments

@russcam
Copy link
Contributor

russcam commented Oct 9, 2019 •
edited
Loading

In line with other REST API specs that accept a comma-separated list of values, the slm.get_lifecycle REST API spec policy_id should be of type "list", and not "string":

elasticsearch/x-pack/plugin/src/test/resources/rest-api-spec/api/slm.get_lifecycle.json

Lines 14 to 19 in 603c3e6

"parts":{
"policy_id":{
"type":"string",
"description":"Comma-separated list of snapshot lifecycle policies to retrieve"
}
}

This affects REST specs back to v7.4.0.

The docs should also be updated to use policy_id instead of policy_ids, to match the REST API spec.
@russcam russcam mentioned this issue Oct 9, 2019
Merged
russcam added a commit that referenced this issue Oct 9, 2019
@russcam
Change policy_id to list type in slm.get_lifecycle
054203a 
This commit changes the REST API spec slm.get_lifecycle's polict_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values.

Closes #47765
@jimczi jimczi added :Core/Infra/REST API REST infrastructure and utilities >bug labels Oct 9, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/REST API)

russcam added a commit that referenced this issue Oct 24, 2019
@russcam
Change policy_id to list type in slm.get_lifecycle (#47766)
19b9fb6 
This commit changes the REST API spec slm.get_lifecycle's policy_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values.

Closes #47765
russcam added a commit that referenced this issue Oct 24, 2019
@russcam
Change policy_id to list type in slm.get_lifecycle (#47766)
b24bbd4 
This commit changes the REST API spec slm.get_lifecycle's policy_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values.

Closes #47765
russcam added a commit that referenced this issue Oct 24, 2019
@russcam
Change policy_id to list type in slm.get_lifecycle (#47766)
7c55fde 
This commit changes the REST API spec slm.get_lifecycle's policy_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values.

Closes #47765
russcam added a commit that referenced this issue Oct 24, 2019
@russcam
Change policy_id to list type in slm.get_lifecycle (#47766)
0bdce01 
This commit changes the REST API spec slm.get_lifecycle's policy_id url part to be of type "list", in line with other REST API specs that accept a comma-separated list of values.

Closes #47765
@Mpdreamz Mpdreamz mentioned this issue Nov 19, 2019
Closed
24 tasks
This was referenced Feb 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
>bug :Core/Infra/REST API REST infrastructure and utilities
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change policy_id to list type in slm.get_lifecycle elastic/elasticsearch
3 participants
@russcam @elasticmachine @jimczi