Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TimeSeriesLifecycleActionsIT.testExplainFilters fails due to ILM retries #48767

Closed
dakrone opened this issue Oct 31, 2019 · 1 comment · Fixed by #48772
Closed

TimeSeriesLifecycleActionsIT.testExplainFilters fails due to ILM retries #48767

dakrone opened this issue Oct 31, 2019 · 1 comment · Fixed by #48772
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test-failure Triaged test failures from CI

Comments

@dakrone
Copy link
Member

dakrone commented Oct 31, 2019

It's possible for the testExplainFilters test to fail due to ILM retrying the failed step and thus not being in the failed step. This causes an exception like:

java.lang.AssertionError: 
Expected: (map containing ["iaelhhxvxf-error"->ANYTHING] and map containing ["iaelhhxvxf-nonexistant-policy"->ANYTHING])
     but: map containing ["iaelhhxvxf-error"->ANYTHING] map was [<iaelhhxvxf-nonexistant-policy={index=iaelhhxvxf-nonexistant-policy, managed=true, policy=Xrtic, step_info={type=illegal_argument_exception, reason=policy [Xrtic] does not exist}}>]
	at __randomizedtesting.SeedInfo.seed([F284FECD14016E34:74B0734551DA485]:0)
	at org.hamcrest.MatcherAssert.assertThat(MatcherAssert.java:18)
	at org.junit.Assert.assertThat(Assert.java:956)
	at org.junit.Assert.assertThat(Assert.java:923)
	at org.elasticsearch.xpack.ilm.TimeSeriesLifecycleActionsIT.lambda$testExplainFilters$47(TimeSeriesLifecycleActionsIT.java:866)
	at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:867)
	at org.elasticsearch.test.ESTestCase.assertBusy(ESTestCase.java:840)
	at org.elasticsearch.xpack.ilm.TimeSeriesLifecycleActionsIT.testExplainFilters(TimeSeriesLifecycleActionsIT.java:853)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62)
	at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.base/java.lang.reflect.Method.invoke(Method.java:566)
	at com.carrotsearch.randomizedtesting.RandomizedRunner.invoke(RandomizedRunner.java:1750)
	at com.carrotsearch.randomizedtesting.RandomizedRunner$8.evaluate(RandomizedRunner.java:938)

https://elasticsearch-ci.elastic.co/job/elastic+elasticsearch+pull-request-2/10081/testReport/junit/org.elasticsearch.xpack.ilm/TimeSeriesLifecycleActionsIT/testExplainFilters/
https://gradle-enterprise.elastic.co/s/rgyylclrstq2o

The test should use a non-retryable error to simulate a policy in error, so that ILM doesn't auto-retry it and move the index out of the ERROR step.
@dakrone dakrone added >test-failure Triaged test failures from CI :Data Management/ILM+SLM Index and Snapshot lifecycle management labels Oct 31, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-features (:Core/Features/ILM+SLM)

@dakrone dakrone mentioned this issue Oct 31, 2019
Merged
dakrone added a commit to dakrone/elasticsearch that referenced this issue Oct 31, 2019
@dakrone
Fix TimeSeriesLifecycleActionsIT.testExplainFilters
125cd8b 
This test used an index without an alias to simulate a failure in the
`check-rollover-ready` step. However, with elastic#48256 that step
automatically retries, meaning that the index may not always be in
the ERROR step.

This commit changes the test to use a shrink action with an invalid
number of shards so that it stays in the ERROR step.

Resolves elastic#48767
@dakrone dakrone mentioned this issue Oct 31, 2019
Merged
dakrone added a commit that referenced this issue Oct 31, 2019
@dakrone
Fix TimeSeriesLifecycleActionsIT.testExplainFilters (#48772)
b0477ae 
This test used an index without an alias to simulate a failure in the
`check-rollover-ready` step. However, with #48256 that step
automatically retries, meaning that the index may not always be in
the ERROR step.

This commit changes the test to use a shrink action with an invalid
number of shards so that it stays in the ERROR step.

Resolves #48767
dakrone added a commit to dakrone/elasticsearch that referenced this issue Oct 31, 2019
@dakrone
Fix TimeSeriesLifecycleActionsIT.testExplainFilters (elastic#48772)
52b300e 
This test used an index without an alias to simulate a failure in the
`check-rollover-ready` step. However, with elastic#48256 that step
automatically retries, meaning that the index may not always be in
the ERROR step.

This commit changes the test to use a shrink action with an invalid
number of shards so that it stays in the ERROR step.

Resolves elastic#48767
dakrone added a commit that referenced this issue Oct 31, 2019
@dakrone
[7.x] Fix TimeSeriesLifecycleActionsIT.testExplainFilters (#48… (#48776)
d0ead68 
This test used an index without an alias to simulate a failure in the
`check-rollover-ready` step. However, with #48256 that step
automatically retries, meaning that the index may not always be in
the ERROR step.

This commit changes the test to use a shrink action with an invalid
number of shards so that it stays in the ERROR step.

Resolves #48767
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Data Management/ILM+SLM Index and Snapshot lifecycle management >test-failure Triaged test failures from CI
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix TimeSeriesLifecycleActionsIT.testExplainFilters dakrone/elasticsearch
2 participants
@dakrone @elasticmachine