Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

logs about updating IndexSetting should be more detailed #49818

Closed
kkewwei opened this issue Dec 4, 2019 · 5 comments
Closed

logs about updating IndexSetting should be more detailed #49818

kkewwei opened this issue Dec 4, 2019 · 5 comments
Labels
:Core/Infra/Settings Settings infrastructure and APIs >enhancement good first issue low hanging fruit help wanted adoptme

Comments

@kkewwei
Copy link
Contributor

kkewwei commented Dec 4, 2019 •
edited
Loading

ES_VERSION: 7.3.1
Description of the problem including expected versus actual behavior:
When updating index setting like this:
PUT index1/_settings { "index": { "merge": { "policy": { "max_merge_at_once": "5" } } } }
and relevent log is:
[2019-12-03T21:59:14,065][INFO ][o.e.c.s.IndexScopedSettings] [node-1] updating [index.merge.policy.max_merge_at_once] from [10] to [5]
according to the log, I don't know which index is updated, If we could add the index name in the log.
@DaveCTurner DaveCTurner added :Core/Infra/Settings Settings infrastructure and APIs >enhancement labels Dec 4, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Settings)

@DaveCTurner DaveCTurner added good first issue low hanging fruit help wanted adoptme labels Dec 4, 2019
@DaveCTurner
Copy link
Contributor

Seems like a reasonable thing to want @kkewwei. Would you care to work on a PR?

@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 4, 2019

It's my pleasure to do it.

@rachana-prajapati
Copy link

Is this item still open?

@kkewwei kkewwei mentioned this issue Dec 8, 2019
Merged
@kkewwei
Copy link
Contributor Author

kkewwei commented Dec 9, 2019

@rachana-prajapati, yes, you can see it it the pr.

DaveCTurner pushed a commit that referenced this issue Jan 3, 2020
@DaveCTurner
Log index name when updating index settings (#49969)
5655d6a 
Today we log changes to index settings like this:

    updating [index.setting.blah] from [A] to [B]

The identity of the index whose settings were updated is conspicuously absent
from this message. This commit addresses this by adding the index name to these
messages.

Fixes #49818.
SivagurunathanV pushed a commit to SivagurunathanV/elasticsearch that referenced this issue Jan 23, 2020
@SivagurunathanV
Log index name when updating index settings (elastic#49969)
588d6eb 
Today we log changes to index settings like this:

    updating [index.setting.blah] from [A] to [B]

The identity of the index whose settings were updated is conspicuously absent
from this message. This commit addresses this by adding the index name to these
messages.

Fixes elastic#49818.
This was referenced Feb 3, 2020
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Settings Settings infrastructure and APIs >enhancement good first issue low hanging fruit help wanted adoptme
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@DaveCTurner @elasticmachine @kkewwei @rachana-prajapati