Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compatible warnings logger #52369

Closed
pgomulka opened this issue Feb 14, 2020 · 1 comment · Fixed by #57739
Closed

Compatible warnings logger #52369

pgomulka opened this issue Feb 14, 2020 · 1 comment · Fixed by #57739
Labels
:Core/Infra/Logging Log management and logging utilities Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1

Comments

@pgomulka
Copy link
Contributor

when accessing a rest compatible api we often will want to emit a warning that the endpoint is being accessed is only compatible and a user should upgrade to newer version.
This should most likely reuse deprecation logger logic.

relates #51816
@pgomulka pgomulka added :Core/Infra/Logging Log management and logging utilities v8.0.0 labels Feb 14, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra (:Core/Infra/Logging)

@pgomulka pgomulka changed the title Implement Compatible logger Compatible warnings logger Feb 18, 2020
@pgomulka pgomulka mentioned this issue Apr 24, 2020
Closed
@pgomulka pgomulka mentioned this issue May 4, 2020
Merged
@rjernst rjernst added the Team:Core/Infra Meta label for core/infra team label May 4, 2020
pgomulka added a commit that referenced this issue Jun 1, 2020
@pgomulka
Header warning logging refactoring (#55941)
4d6dc51 
Splitting DeprecationLogger into two. HeaderWarningLogger - responsible for adding a response warning headers and ThrottlingLogger - responsible for limiting the duplicated log entries for the same key (previously deprecateAndMaybeLog).
Introducing A ThrottlingAndHeaderWarningLogger which is a base for other common logging usages where both response warning header and logging throttling was needed.

relates #55699
relates #52369
pgomulka added a commit to pgomulka/elasticsearch that referenced this issue Aug 25, 2020
@pgomulka
Header warning logging refactoring backport(elastic#55941)
08d6f63 
Splitting DeprecationLogger into two. HeaderWarningLogger - responsible for adding a response warning headers and ThrottlingLogger - responsible for limiting the duplicated log entries for the same key (previously deprecateAndMaybeLog).
Introducing A ThrottlingAndHeaderWarningLogger which is a base for other common logging usages where both response warning header and logging throttling was needed.

relates elastic#55699
relates elastic#52369
@pgomulka pgomulka mentioned this issue Aug 25, 2020
Merged
pgomulka added a commit that referenced this issue Aug 25, 2020
@pgomulka
Header warning logging refactoring backport(#55941) (#61515)
f3f7d25 
Splitting DeprecationLogger into two. HeaderWarningLogger - responsible for adding a response warning headers and ThrottlingLogger - responsible for limiting the duplicated log entries for the same key (previously deprecateAndMaybeLog).
Introducing A ThrottlingAndHeaderWarningLogger which is a base for other common logging usages where both response warning header and logging throttling was needed.

relates #55699
relates #52369
backports #55941
@rjernst rjernst added the needs:triage Requires assignment of a team area label label Dec 3, 2020
@pgomulka pgomulka removed the needs:triage Requires assignment of a team area label label Dec 18, 2020
@pgomulka pgomulka mentioned this issue Dec 18, 2020
Merged
pgomulka added a commit that referenced this issue Feb 15, 2021
@pgomulka
Compatible Api warnings logging (#57739)
46de21b 
Extending deprecation logger to also log compatible API warnings.
These warnings will be written to deprecation log file, data stream and will emit response warning header - the same as deprecation logs. In order to comply with constant keyword type of data_stream.datatype the value will have to be the same for compatible and deprecation log - elasticsearch.deprecation.
The compatible and deprecation logs will differ by elasticsearch.event.category field which will always be DeprecationCategory.COMPATIBLE_API for all compatible logs

closes #52369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
:Core/Infra/Logging Log management and logging utilities Team:Core/Infra Meta label for core/infra team v8.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Compatible Api warnings logging pgomulka/elasticsearch
4 participants
@rjernst @jakelandis @pgomulka @elasticmachine