Don't try to delete watcher history backing indices in ESRestTestCase.wipeAllIndices(...) #106144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joegallo
added
>test
|
Pinging @elastic/es-data-management (Team:Data Management) |
masseyke
reviewed
Mar 8, 2024
| @@ -1103,8 +1103,8 @@ protected static void wipeAllIndices() throws IOException { | |||
| protected static void wipeAllIndices(boolean preserveSecurityIndices) throws IOException { | |||
| boolean includeHidden = clusterHasFeature(RestTestLegacyFeatures.HIDDEN_INDICES_SUPPORTED); | |||
| try { | |||
| // remove all indices except ilm and slm history which can pop up after deleting all data streams but shouldn't interfere | |||
| final List<String> indexPatterns = new ArrayList<>(List.of("*", "-.ds-ilm-history-*", "-.ds-.slm-history-*")); | |||
| // remove all indices except data stream backing indices, since they have to be removed their own special way, anyway | |||
There was a problem hiding this comment.
Should we just add -.ds-.watcher-history-* as a smaller step that would still fix these two tests? The problem is that watcher history is written asynchronously. That's not necessarily the case with every datastream
There was a problem hiding this comment.
Sure, that's fine. I'll change it to that.
joegallo
changed the title
joegallo
changed the title
|
ARGH. Of course I meant |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #93848
Closes #99517
See also #100694 and #64521 for the history of this
DELETE.