Allow to disable jarhell check for tests on 2.2 with test.jarhell.check
#16174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eck` This relates to elastic#16042 where we agreed on adding an opt-out on 2.2 for test to disable jarhell checks in the BootstrapForTesting.java - for other branches we will use different solutoins.
|
@clintongormley can you take a look? |
|
LGTM |
| JarHell.checkJarHell(); | ||
| } catch (Exception e) { | ||
| throw new RuntimeException("found jar hell in test classpath", e); | ||
| } |
There was a problem hiding this comment.
Should we log that jar hell has been deactivated?
There was a problem hiding this comment.
there is no logger here anyway... hot topic :)
There was a problem hiding this comment.
haha! I was pretty sure you were going to answer that :)
s1monw
added a commit
that referenced
this pull request
Jan 22, 2016
Allow to disable jarhell check for tests on 2.2 with `test.jarhell.check`
brwe
added a commit
to brwe/elasticsearch
that referenced
this pull request
Feb 26, 2016
Otherwise it will not be picked up when running the tests from command line. relates to elastic#16174
s1monw
added a commit
that referenced
this pull request
Mar 13, 2016
Allow to disable jarhell check for tests on 2.2 with `test.jarhell.check`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relates to #16042 where we agreed on adding an opt-out on 2.2 for test
to disable jarhell checks in the BootstrapForTesting.java - for other branches we
will use different solutions.