Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add POM generation for meta-plugins #28319

Closed
wants to merge 2 commits into from

Conversation

jasontedor
Copy link
Member

This commit adds a POM generation task for the ZIP distribution for meta-plugins. With this change we also modify MetaPluginBuildPlugin to extend BuildPlugin (because we need POM generation configuration from there), remove standalone and REST test plugins, and manually create an integTest task. To simplify this, we abstract out some shared code from PluginBuildPlugin so that it can be reused in MetaPluginBuildPlugin.

This commit adds a POM generation task for the ZIP distribution for
meta-plugins. With this change we also modify MetaPluginBuildPlugin to
extend BuildPlugin (because we need POM generation configuration from
there), remove standalone and REST test plugins, and manually create an
integTest task. To simplify this, we abstract out some shared code from
PluginBuildPlugin so that it can be reused in MetaPluginBuildPlugin.
Copy link
Member

@rjernst rjernst left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hrm, I don't think meta plugins should extend from BuildPlugin. They should not have any code (and build plugin is for a Java code). Meta plugins don't build a jar, they simply zip the zips from other plugins. I think we can just add pom generation directly?

@rjernst
Copy link
Member

rjernst commented Jan 21, 2018

@jasontedor I opened #28321 with my proposed alternative.

@jasontedor jasontedor closed this Jan 21, 2018
@mark-vieira mark-vieira added the Team:Delivery Meta label for Delivery team label Nov 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker :Delivery/Build Build or test infrastructure Team:Delivery Meta label for Delivery team v6.2.0 v6.3.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants