-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove Painless Type from e-nodes in favor of Java Class #28364
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
public static Class<?> TypeToClass (Type type) { | ||
if (type.dynamic) { | ||
public static Class<?> TypeToClass(Type type) { | ||
if ("def".equals(type.struct.name)) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe use def.class.getShortName()
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated for all of Definition.
@rjernst Thanks for the review. Will commit as soon as CI completes. |
This is the fourth part in a series to remove Painless Type. This replaces Painless Type with Java Class for all expression type nodes in Painless. This is a somewhat large change because the base node for all expression nodes is modified and can't really be broken up.