Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarifies how the query_string splits textual part to build a query #28798

Merged
merged 2 commits into from
Mar 1, 2018
Merged

Clarifies how the query_string splits textual part to build a query #28798

merged 2 commits into from
Mar 1, 2018

Conversation

jimczi
Copy link
Contributor

@jimczi jimczi commented Feb 23, 2018

Whitespaces are not considered as operators anymore in 6x but the documentation is not clear about it.
This commit changes the example in the documentation and adds a note regarding whitespaces and operators.

Closes #28719

@jimczi
Clarifies how the query_string splits textual part to build a query
39a9251 
Whitespaces are not considered as operators anymore in 6x but the documentation is not clear about it.
This commit changes the example in the documentation and adds a note regarding whitespaces and operators.

Closes elastic#28719
@jimczi jimczi added >docs General docs changes :Search/Search Search-related issues that do not fall into other categories labels Feb 23, 2018
dakrone
dakrone approved these changes Feb 23, 2018
View reviewed changes
Copy link
Member

@dakrone dakrone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I left grammatical comments, but no need for another review once they're addressed

docs/reference/query-dsl/query-string-query.asciidoc Outdated
}
}
}
--------------------------------------------------
// CONSOLE

... will be splitted in `new`, `york` and `city` and each part is analyzed independently.
... will be splitted in `new york city` and `big apple` and each part is then
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"will be spitted in" -> "will be split into"

docs/reference/query-dsl/query-string-query.asciidoc Outdated
... will be splitted in `new york city` and `big apple` and each part is then
analyzed independently by the analyzer configured for the field.

WARNING: Whitespaces are not considered as operators, this means that `new york city`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove "as"

docs/reference/query-dsl/query-string-query.asciidoc Outdated
analyzed independently by the analyzer configured for the field.

WARNING: Whitespaces are not considered as operators, this means that `new york city`
will be pass "as is" to the analyzer configured for the field. If the field is a `keyword`
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pass -> passed

@jimczi jimczi merged commit 48a7425 into elastic:master Mar 1, 2018
@jimczi jimczi deleted the query_string_docs branch March 1, 2018 23:08
jimczi added a commit that referenced this pull request Mar 1, 2018
@jimczi
Clarifies how query_string splits textual part (#28798)
3079dff 
* Clarifies how the query_string splits textual part to build a query

Whitespaces are not considered as operators anymore in 6x but the documentation is not clear about it.
This commit changes the example in the documentation and adds a note regarding whitespaces and operators.

Closes #28719
jimczi added a commit that referenced this pull request Mar 1, 2018
@jimczi
Clarifies how query_string splits textual part (#28798)
3e1e050 
* Clarifies how the query_string splits textual part to build a query

Whitespaces are not considered as operators anymore in 6x but the documentation is not clear about it.
This commit changes the example in the documentation and adds a note regarding whitespaces and operators.

Closes #28719
jimczi added a commit that referenced this pull request Mar 1, 2018
@jimczi
Clarifies how query_string splits textual part (#28798)
2204383 
* Clarifies how the query_string splits textual part to build a query

Whitespaces are not considered as operators anymore in 6x but the documentation is not clear about it.
This commit changes the example in the documentation and adds a note regarding whitespaces and operators.

Closes #28719
jimczi added a commit that referenced this pull request Mar 1, 2018
@jimczi
Clarifies how query_string splits textual part (#28798)
116165f 
* Clarifies how the query_string splits textual part to build a query

Whitespaces are not considered as operators anymore in 6x but the documentation is not clear about it.
This commit changes the example in the documentation and adds a note regarding whitespaces and operators.

Closes #28719
@fbaligand fbaligand mentioned this pull request Mar 2, 2018
Merged
martijnvg added a commit that referenced this pull request Mar 8, 2018
@martijnvg
Merge remote-tracking branch 'es/master' into ccr
bfd587d 
* es/master: (48 commits)
  Update bucket-sort-aggregation.asciidoc (#28937)
  [Docs] REST high-level client: Fix code for most basic search request (#28916)
  Improved percolator's random candidate query duel test and fixed bugs that were exposed by this:
  Revert "Rescore collapsed documents (#28521)"
  Build: Fix test logger NPE when no tests are run (#28929)
  [TEST] AwaitsFix QueryRescorerIT.testRescoreAfterCollapse
  Decouple XContentType from StreamInput/Output (#28927)
  Remove BytesRef usage from XContentParser and its subclasses (#28792)
  [DOCS] Correct typo in configuration (#28903)
  Fix incorrect datemath example (#28904)
  Add a usage example of the JLH score (#28905)
  Wrap stream passed to createParser in try-with-resources (#28897)
  Rescore collapsed documents (#28521)
  Fix (simple)_query_string to ignore removed terms (#28871)
  [Docs] Fix typo in composite aggregation (#28891)
  Try if tombstone is eligable for pruning before locking on it's key (#28767)
  Limit analyzed text for highlighting (improvements) (#28808)
  Missing `timeout` parameter from the REST API spec JSON files (#28328)
  Clarifies how query_string splits textual part (#28798)
  Update outdated java version reference (#28870)
  ...
martijnvg added a commit that referenced this pull request Mar 8, 2018
@martijnvg
Merge remote-tracking branch 'es/6.x' into ccr-6.x
144882b 
* es/6.x: (48 commits)
  Update bucket-sort-aggregation.asciidoc (#28937)
  [Docs] REST high-level client: Fix code for most basic search request (#28916)
  Improved percolator's random candidate query duel test and fixed bugs that were exposed by this:
  Revert "Rescore collapsed documents (#28521)"
  Build: Fix test logger NPE when no tests are run (#28929)
  [TEST] AwaitsFix QueryRescorerIT.testRescoreAfterCollapse
  Decouple XContentType from StreamInput/Output (#28927)
  Remove BytesRef usage from XContentParser and its subclasses (#28792)
  Add doc note for -server flag on Windows service
  [DOCS] Correct typo in configuration (#28903)
  Fix incorrect datemath example (#28904)
  Add a usage example of the JLH score (#28905)
  Limit analyzed text for highlighting (improvements) (#28907)
  Wrap stream passed to createParser in try-with-resources (#28897)
  [Docs] Fix typo in composite aggregation (#28891)
  Rescore collapsed documents (#28521)
  Fix (simple)_query_string to ignore removed terms (#28871)
  Missing `timeout` parameter from the REST API spec JSON files (#28328)
  Clarifies how query_string splits textual part (#28798)
  Update outdated java version reference (#28870)
  ...
sebasjm pushed a commit to sebasjm/elasticsearch that referenced this pull request Mar 10, 2018
@jimczi
Clarifies how query_string splits textual part (elastic#28798)
aef9575 
* Clarifies how the query_string splits textual part to build a query

Whitespaces are not considered as operators anymore in 6x but the documentation is not clear about it.
This commit changes the example in the documentation and adds a note regarding whitespaces and operators.

Closes elastic#28719
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dakrone dakrone dakrone approved these changes

Assignees
No one assigned
Labels
>docs General docs changes :Search/Search Search-related issues that do not fall into other categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jimczi @dakrone