Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align cat thread pool info to thread pool config #29195

Merged
merged 5 commits into from
Apr 3, 2018
Merged

Align cat thread pool info to thread pool config #29195

merged 5 commits into from
Apr 3, 2018

Conversation

jasontedor
Copy link
Member

@jasontedor jasontedor commented Mar 21, 2018 •
edited
Loading

Today we report thread pool info using a common object. This means that we use a shared set of terminology that is not consistent with the terminology used to the configure thread pools. This holds in particular for the minimum and maximum number of threads in the thread pool where we use the following terminology:

 thread pool info | fixed | scaling
  min                core    size
  max                max     size

A previous change addressed this for the nodes info API. This commit changes the display of thread pool info in the cat thread pool API too to be dependent on the type of the thread pool so that we can align the terminology in the output of thread pool info with the terminology used to configure a thread pool.

Relates #29123

@jasontedor
Align cat thread pool info to thread pool config
903e1a8 
Today we report thread pool info using a common object. This means that
we use a shared set of terminology that is not consistent with the
terminology used to the configure thread pools. This holds in particular
for the minimum and maximum number of threads in the thread pool where
we use the following terminology:
 thread pool info | fixed | scaling
  min                core    size
  max                max     size

A previous change addressed this for the nodes info API. This commit
changes the display of thread pool info in the cat thread pool API too
to be dependent on the type of the thread pool so that we can align the
terminology in the output of thread pool info with the terminology used
to configure a thread pool.
@jasontedor jasontedor added >breaking review :Data Management/Stats Statistics tracking and retrieval APIs v7.0.0 labels Mar 21, 2018
@jasontedor
Copy link
Member Author

I would like to integrate this change, then I will update the docs change in #29192 to reflect the changes here too.

@jasontedor jasontedor mentioned this pull request Mar 21, 2018
Merged
spinscale
spinscale suggested changes Mar 26, 2018
View reviewed changes
Copy link
Contributor

@spinscale spinscale left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there is a docs/reference/cat/thread_pool.asciidoc, that refers to the size parameter. I am not sure if we should maintain the fields in the docs, because that's what the help is for - maybe just get rid of that table?

@jasontedor
Merge branch 'master' into align-thread-pool-info-cat-api
1112584 
* master: (80 commits)
  Remove HTTP max content length leniency (elastic#29337)
  Begin moving XContent to a separate lib/artifact (elastic#29300)
  Java versions for ci (elastic#29320)
  Minor cleanup in the InternalEngine (elastic#29241)
  Clarify expectations of false positives/negatives (elastic#27964)
  Update docs on vertex ordering (elastic#27963)
  Revert "REST high-level client: add support for Indices Update Settings API (elastic#28892)" (elastic#29323)
  [test] remove Streamable serde assertions (elastic#29307)
  Improve query string docs (elastic#28882)
  fix query string example for boolean query (elastic#28881)
  Resolve unchecked cast warnings introduced with elastic#28892
  REST high-level client: add support for Indices Update Settings API (elastic#28892)
  Search: Validate script query is run with a single script (elastic#29304)
  [DOCS] Added info on WGS-84. Closes issue elastic#3590 (elastic#29305)
  Increase timeout on Netty client latch for tests
  Build: Use branch specific refspec sysprop for bwc builds (elastic#29299)
  TEST: trim unsafe commits before opening engine
  Move trimming unsafe commits from engine ctor to store (elastic#29260)
  Fix incorrect geohash for lat 90, lon 180 (elastic#29256)
  Do not load global state when deleting a snapshot (elastic#29278)
  ...
@jasontedor
Merge branch 'master' into align-thread-pool-info-cat-api
5d60e36 
* master:
  Reindex: Fix error in delete-by-query rest spec (elastic#29318)
  Improve similarity integration. (elastic#29187)
  Fix some query extraction bugs. (elastic#29283)
  [Docs] Correct experimental note formatting
  Move Nullable into core (elastic#29341)
  [Docs] Update getting-started.asciidoc (elastic#29294)
  Elasticsearch 6.3.0 is now on Lucene 7.3.
  [DOCS] Refer back to index API for full-document updates in _update API section (elastic#28677)
  Fix missing comma in ingest-node.asciidoc (elastic#29343)
  Improve exception handling on TransportMasterNodeAction (elastic#29314)
  Don't break allocation if resize source index is missing (elastic#29311)
  Use fixture to test repository-s3 plugin (elastic#29296)
  Fix NDCG for empty search results (elastic#29267)
  Pass through script params in scripted metric agg (elastic#29154)
  Fix Eclipse build.
  Upgrade to lucene-7.3.0-snapshot-98a6b3d. (elastic#29298)
  Painless: Remove extraneous INLINE constant. (elastic#29340)
@jasontedor
Update docs
725e4af
@jasontedor
Copy link
Member Author

Thanks @spinscale, I have updated the docs. For now I elect to keep the table and we can consider removing it in a follow-up separate from this change as I think making such a change to the docs should be more visible. Would you take another look?

spinscale
spinscale approved these changes Apr 3, 2018
View reviewed changes
Copy link
Contributor

@spinscale spinscale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasontedor jasontedor merged commit 8fdca6a into elastic:master Apr 3, 2018
@jasontedor jasontedor deleted the align-thread-pool-info-cat-api branch April 3, 2018 21:27
@jasontedor
Copy link
Member Author

Thanks @spinscale.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Apr 4, 2018
@jasontedor
Merge branch 'master' into byte-size-value-setting-limit-error-message
1415e2b 
* master:
  Remove silent batch mode from install plugin (elastic#29359)
  Align cat thread pool info to thread pool config (elastic#29195)
  Track Lucene operations in engine explicitly (elastic#29357)
martijnvg added a commit that referenced this pull request Apr 5, 2018
@martijnvg
Merge remote-tracking branch 'es/master' into ccr
1f306c3 
* es/master: (68 commits)
  Allow using distance measure in the geo context precision (#29273)
  Disable failing query in QueryBuilderBWCIT.
  Fixed quote_field_suffix in query_string (#29332)
  Use fixture to test repository-url module (#29355)
  Remove undocumented action.master.force_local setting (#29351)
  Enhance error for out of bounds byte size settings (#29338)
  Fix QueryAnalyzerTests.
  Fix HasChildQueryBuilderTests to not use the `classic` similarity.
  [Docs] Correct javadoc of GetIndexRequest (#29364)
  Make TransportRankEvalAction members final
  Add awaits fix for a query analyzer test
  Check presence of multi-types before validating new mapping (#29316)
  Add awaits fix for HasChildQueryBuilderTests
  Remove silent batch mode from install plugin (#29359)
  Align cat thread pool info to thread pool config (#29195)
  Track Lucene operations in engine explicitly (#29357)
  Build: Fix Java9 MR build (#29312)
  Reindex: Fix error in delete-by-query rest spec (#29318)
  Improve similarity integration. (#29187)
  Fix some query extraction bugs. (#29283)
  ...
@jasontedor jasontedor mentioned this pull request Apr 5, 2018
Merged
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Apr 5, 2018
@jasontedor
Merge branch 'master' into thread-pool-info-migration
c7dae3c 
* master: (110 commits)
  Remove undocumented action.master.force_local setting (elastic#29351)
  Enhance error for out of bounds byte size settings (elastic#29338)
  Fix QueryAnalyzerTests.
  Fix HasChildQueryBuilderTests to not use the `classic` similarity.
  [Docs] Correct javadoc of GetIndexRequest (elastic#29364)
  Make TransportRankEvalAction members final
  Add awaits fix for a query analyzer test
  Check presence of multi-types before validating new mapping (elastic#29316)
  Add awaits fix for HasChildQueryBuilderTests
  Remove silent batch mode from install plugin (elastic#29359)
  Align cat thread pool info to thread pool config (elastic#29195)
  Track Lucene operations in engine explicitly (elastic#29357)
  Build: Fix Java9 MR build (elastic#29312)
  Reindex: Fix error in delete-by-query rest spec (elastic#29318)
  Improve similarity integration. (elastic#29187)
  Fix some query extraction bugs. (elastic#29283)
  [Docs] Correct experimental note formatting
  Move Nullable into core (elastic#29341)
  [Docs] Update getting-started.asciidoc (elastic#29294)
  Elasticsearch 6.3.0 is now on Lucene 7.3.
  ...
russcam added a commit to elastic/elasticsearch-net that referenced this pull request Jun 20, 2019
@russcam
Align Cat Threadpool properties
5094542 
Relates: elastic/elasticsearch#29195
@russcam russcam mentioned this pull request Jun 20, 2019
Merged
Mpdreamz pushed a commit to elastic/elasticsearch-net that referenced this pull request Jun 20, 2019
@russcam @Mpdreamz
Align Cat Threadpool properties (#3844)
b75b735 
Relates: elastic/elasticsearch#29195
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spinscale spinscale spinscale approved these changes

Assignees
No one assigned
Labels
>breaking :Data Management/Stats Statistics tracking and retrieval APIs v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jasontedor @spinscale @colings86