Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Switch many QA projects to use new style requests #30574

Merged
merged 3 commits into from
May 15, 2018

Conversation

nik9000
Copy link
Member

@nik9000 nik9000 commented May 14, 2018

In #29623 we added Request object flavored requests to the low level
REST client and in #30315 we deprecated the the old requests. This
changes many calls in the qa projects to use the new version.

In elastic#29623 we added `Request` object flavored requests to the low level
REST client and in elastic#30315 we deprecated the the old requests. This
changes many calls in the `qa` projects to use the new version.
@nik9000 nik9000 added >test Issues or PRs that are addressing/adding tests review :Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch v7.0.0 v6.4.0 labels May 14, 2018
@nik9000 nik9000 requested a review from javanna May 14, 2018 14:07
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@javanna javanna left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks @nik9000

Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@nik9000 nik9000 merged commit 6695d11 into elastic:master May 15, 2018
nik9000 added a commit that referenced this pull request May 16, 2018
In #29623 we added `Request` object flavored requests to the low level
REST client and in #30315 we deprecated the the old requests. This
changes many calls in the `qa` projects to use the new version.
@nik9000
Copy link
Member Author

nik9000 commented May 16, 2018

Thanks for the reviews @javanna and @jasontedor! I've merged to master and backported to 6.x.

jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request May 16, 2018
…bad-mkay

* elastic/6.x:
  [ML] Wait for ML indices in rolling upgrade tests (elastic#30615)
  Watcher: Ensure secrets integration tests also run triggered watch (elastic#30478)
  Move allocation awareness attributes to list setting (elastic#30626)
  [Docs] Update code snippet in has-child-query.asciidoc (elastic#30510)
  Allow date math for naming newly-created snapshots (elastic#7939) (elastic#30479)
  Awaits fix a failing test
  Switch many QA projects to use new style requests (elastic#30574)
  QA: System property to override distribution (elastic#30591)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Clients/Java Low Level REST Client Minimal dependencies Java Client for Elasticsearch >test Issues or PRs that are addressing/adding tests v6.4.0 v7.0.0-beta1
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants