Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Adds release highlight pages #30590

Merged
merged 2 commits into from
May 14, 2018
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented May 14, 2018

This PR creates the file structure for a new set of "release highlight" pages.

These highlight pages will summarize the most significant changes in each release (starting in 6.3.0).

At this time I have created the highlights at the same level as the release notes in the Elasticsearch Reference's table of contents:
toc

However, once we know the final implementation for the changelog files, we can restructure the table of contents as necessary.

NOTE: At this time, these highlight pages are not meant to replace the blogs that go out with releases (e.g. https://www.elastic.co/blog/elasticsearch-6-2-0-released) though some of the same items might be covered in both places.

@lcawl lcawl added >docs General docs changes v7.0.0 v6.3.0 v6.4.0 labels May 14, 2018
@lcawl lcawl requested review from pcsanwald and debadair May 14, 2018 19:11
Copy link
Contributor

@pcsanwald pcsanwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes LGTM, but don't we also need 6.3 and 6.4? or were you going to do those in their respective branches?

@lcawl
Copy link
Contributor Author

lcawl commented May 14, 2018

I was going to create similar pages in the 6.4, 6.3, and 5.6 branches at this point. If that's not what you had in mind, let me know!

Copy link
Contributor

@pcsanwald pcsanwald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that sounds fine to me. reason I ask is there's an item we wanted to add for 6.4

@lcawl lcawl merged commit 21d67d1 into elastic:master May 14, 2018
@lcawl lcawl deleted the lcawley-highlights branch May 14, 2018 22:49
lcawl added a commit that referenced this pull request May 14, 2018
lcawl added a commit that referenced this pull request May 14, 2018
lcawl added a commit that referenced this pull request May 14, 2018
@lcawl lcawl added the v5.6.10 label May 14, 2018
@javanna
Copy link
Member

javanna commented May 15, 2018

This collided with the removal of the changelog, see #30593 . I pushed a quick fix to master but I am pretty sure it is only a temporary work-around to make the docs build work again. See 098b3b7

@javanna
Copy link
Member

javanna commented May 15, 2018

See also e1d675c for master, and the corresponding e40b884 for 6.x, 35a61de for 6.3 and ada8147 for 5.6. I took the highlights page out of the inclusions as it caused problems.

dnhatn added a commit that referenced this pull request May 15, 2018
* 6.x:
  Revert "Silence IndexUpgradeIT test failures. (#30430)"
  [DOCS] Remove references to changelog and to highlights
  Revert "Mute ML upgrade test (#30458)"
  [ML] Fix BWC version for backport of #30125
  [Docs] Improve section detailing translog usage (#30573)
  [Tests] Relax allowed delta in extended_stats aggregation (#30569)
  Fail if reading from closed KeyStoreWrapper (#30394)
  [ML] Reverse engineer Grok patterns from categorization results (#30125)
  Derive max composite buffers from max content len
  Update build file due to doc file rename
  SQL: Extract SQL request and response classes (#30457)
  Remove the changelog (#30593)
  Revert "Add deprecation warning for default shards (#30587)"
  Silence IndexUpgradeIT test failures. (#30430)
  Add deprecation warning for default shards (#30587)
  [DOCS] Adds 6.4.0 release highlight pages
  [DOCS] Adds release highlight pages (#30590)
  Docs: Document how to rebuild analyzers (#30498)
  [DOCS] Fixes title capitalization in security content
  LLRest: Add equals and hashcode tests for Request (#30584)
  [DOCS] Fix realm setting names (#30499)
  [DOCS] Fix path info for various security files (#30502)
  Docs: document precision limitations of geo_bounding_box (#30540)
  Fix non existing javadocs link in RestClientTests
  Auto-expand replicas only after failing nodes (#30553)
@lcawl
Copy link
Contributor Author

lcawl commented May 15, 2018

Thanks, I've re-added it now that the builds are clean again: elastic/elasticsearch@ c0d639e2778a076e22a88b02028d7fb64bc915eb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants