Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Watcher: Remove never executed code #31135

Merged
merged 2 commits into from
Jun 26, 2018
Merged

Watcher: Remove never executed code #31135

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b7441e
Watcher: Remove never executed code
spinscale Jun 6, 2018
dd56753
Merge branch 'master' into 1806-remove-dead-code
spinscale Jun 25, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions ...plugin/watcher/src/main/java/org/elasticsearch/xpack/watcher/WatcherIndexingListener.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,16 +110,6 @@ public Engine.Index preIndex(ShardId shardId, Engine.Index operation) {
return operation;
}

// the watch status is -1, in case a watch has been freshly stored and this save
// watch operation does not stem from an execution
// we dont need to update the trigger service, when the watch has been updated as
// part of an execution, so we can exit early
boolean isWatchExecutionOperation = watch.status().version() != -1;
if (isWatchExecutionOperation) {
logger.debug("not updating trigger for watch [{}], watch has been updated as part of an execution", watch.id());
return operation;
}

boolean shouldBeTriggered = shardAllocationConfiguration.shouldBeTriggered(watch.id());
if (shouldBeTriggered) {
if (watch.status().state().isActive()) {
Expand Down