Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compliant SAML Response destination check #31175

Merged
merged 4 commits into from
Jun 8, 2018

Commits on Jun 7, 2018

  1. Make SAML Response Destination check compliant

    Only validate the Destination element of an incoming SAML Response
    if the SAML Response is signed.
    The standard [1] - 3.5.5.2 and [2] - 3.2.2 does mention that the
    Destination element is optional and should only be verified when
    the SAML Response is signed. Some Identity Provider implementations
    are known to not set a Destination XML Attribute in their SAML
    responses when those are not signed, so this change also aims to
    enhance interoperability.
    
    [1] https://docs.oasis-open.org/security/saml/v2.0/saml-bindings-2.0-os.pdf
    [2] https://docs.oasis-open.org/security/saml/v2.0/saml-core-2.0-os.pdf
    jkakavas committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    c849c54 View commit details
    Browse the repository at this point in the history
  2. Adds test

    jkakavas committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    03dabc6 View commit details
    Browse the repository at this point in the history
  3. fix test

    jkakavas committed Jun 7, 2018
    Configuration menu
    Copy the full SHA
    de63176 View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2018

  1. Configuration menu
    Copy the full SHA
    0b74056 View commit details
    Browse the repository at this point in the history