Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename elasticsearch-core to core #31185

Merged
merged 2 commits into from
Jun 7, 2018
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -206,7 +206,7 @@ subprojects {
"org.elasticsearch:rest-api-spec:${version}": ':rest-api-spec',
"org.elasticsearch:elasticsearch:${version}": ':server',
"org.elasticsearch:elasticsearch-cli:${version}": ':server:cli',
"org.elasticsearch:elasticsearch-core:${version}": ':libs:elasticsearch-core',
"org.elasticsearch:elasticsearch-core:${version}": ':libs:core',
"org.elasticsearch:elasticsearch-nio:${version}": ':libs:elasticsearch-nio',
"org.elasticsearch:elasticsearch-x-content:${version}": ':libs:x-content',
"org.elasticsearch:elasticsearch-secure-sm:${version}": ':libs:secure-sm',
Expand Down
2 changes: 1 addition & 1 deletion client/rest/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,7 @@ forbiddenApisTest {
}

// JarHell is part of es server, which we don't want to pull in
// TODO: Not anymore. Now in elasticsearch-core
// TODO: Not anymore. Now in :libs:core
jarHell.enabled=false

namingConventions {
Expand Down
2 changes: 1 addition & 1 deletion client/sniffer/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ dependencyLicenses {
}

// JarHell is part of es server, which we don't want to pull in
// TODO: Not anymore. Now in elasticsearch-core
// TODO: Not anymore. Now in :libs:core
jarHell.enabled=false

namingConventions {
Expand Down
2 changes: 1 addition & 1 deletion client/test/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ forbiddenApisTest {
}

// JarHell is part of es server, which we don't want to pull in
// TODO: Not anymore. Now in elasticsearch-core
// TODO: Not anymore. Now in :libs:core
jarHell.enabled=false

// TODO: should we have licenses for our test deps?
Expand Down
4 changes: 2 additions & 2 deletions libs/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -33,12 +33,12 @@ subprojects {
dependencies.all { Dependency dep ->
Project depProject = dependencyToProject(dep)
if (depProject != null
&& false == depProject.path.equals(':libs:elasticsearch-core')
&& false == depProject.path.equals(':libs:core')
&& false == isEclipse
&& depProject.path.startsWith(':libs')) {
throw new InvalidUserDataException("projects in :libs "
+ "may not depend on other projects libs except "
+ ":libs:elasticsearch-core but "
+ ":libs:core but "
+ "${project.path} depends on ${depProject.path}")
}
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,23 +81,23 @@ dependencies {
java9Compile sourceSets.main.output
}

if (isEclipse == false || project.path == ":libs:elasticsearch-core-tests") {
if (isEclipse == false || project.path == ":libs:core-tests") {
testCompile("org.elasticsearch.test:framework:${version}") {
exclude group: 'org.elasticsearch', module: 'elasticsearch-core'
}
}
}

forbiddenApisMain {
// elasticsearch-core does not depend on server
// TODO: Need to decide how we want to handle for forbidden signatures with the changes to core
// :libs:core does not depend on server
// TODO: Need to decide how we want to handle for forbidden signatures with the changes to server
signaturesURLs = [PrecommitTasks.getResource('/forbidden/jdk-signatures.txt')]
}

if (isEclipse) {
// in eclipse the project is under a fake root, we need to change around the source sets
sourceSets {
if (project.path == ":libs:elasticsearch-core") {
if (project.path == ":libs:core") {
main.java.srcDirs = ['java']
main.resources.srcDirs = ['resources']
} else {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
// this is just shell gradle file for eclipse to have separate projects for elasticsearch-core src and tests
// this is just shell gradle file for eclipse to have separate projects for core src and tests
apply from: '../../build.gradle'
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// this is just shell gradle file for eclipse to have separate projects for elasticsearch-core src and tests
// this is just shell gradle file for eclipse to have separate projects for core src and tests
apply from: '../../build.gradle'

dependencies {
testCompile project(':libs:elasticsearch-core')
testCompile project(':libs:core')
}
2 changes: 1 addition & 1 deletion qa/vagrant/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ dependencies {
compile "org.hamcrest:hamcrest-core:${versions.hamcrest}"
compile "org.hamcrest:hamcrest-library:${versions.hamcrest}"

compile project(':libs:elasticsearch-core')
compile project(':libs:core')

// pulls in the jar built by this project and its dependencies
packagingTest project(path: project.path, configuration: 'runtime')
Expand Down
10 changes: 5 additions & 5 deletions settings.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ if (isEclipse) {
// eclipse cannot handle an intermediate dependency between main and test, so we must create separate projects
// for server-src and server-tests
projects << 'server-tests'
projects << 'libs:elasticsearch-core-tests'
projects << 'libs:core-tests'
projects << 'libs:elasticsearch-nio-tests'
projects << 'libs:x-content-tests'
projects << 'libs:secure-sm-tests'
Expand All @@ -99,10 +99,10 @@ if (isEclipse) {
project(":server").buildFileName = 'eclipse-build.gradle'
project(":server-tests").projectDir = new File(rootProject.projectDir, 'server/src/test')
project(":server-tests").buildFileName = 'eclipse-build.gradle'
project(":libs:elasticsearch-core").projectDir = new File(rootProject.projectDir, 'libs/elasticsearch-core/src/main')
project(":libs:elasticsearch-core").buildFileName = 'eclipse-build.gradle'
project(":libs:elasticsearch-core-tests").projectDir = new File(rootProject.projectDir, 'libs/elasticsearch-core/src/test')
project(":libs:elasticsearch-core-tests").buildFileName = 'eclipse-build.gradle'
project(":libs:core").projectDir = new File(rootProject.projectDir, 'libs/core/src/main')
project(":libs:core").buildFileName = 'eclipse-build.gradle'
project(":libs:core-tests").projectDir = new File(rootProject.projectDir, 'libs/core/src/test')
project(":libs:core-tests").buildFileName = 'eclipse-build.gradle'
project(":libs:elasticsearch-nio").projectDir = new File(rootProject.projectDir, 'libs/elasticsearch-nio/src/main')
project(":libs:elasticsearch-nio").buildFileName = 'eclipse-build.gradle'
project(":libs:elasticsearch-nio-tests").projectDir = new File(rootProject.projectDir, 'libs/elasticsearch-nio/src/test')
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/sql/jdbc/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ dependencies {
compile (project(':libs:x-content')) {
transitive = false
}
compile project(':libs:elasticsearch-core')
compile project(':libs:core')
runtime "com.fasterxml.jackson.core:jackson-core:${versions.jackson}"

testCompile "org.elasticsearch.test:framework:${version}"
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/sql/sql-proto/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ dependencies {
compile (project(':server')) {
transitive = false
}
compile (project(':libs:elasticsearch-core')) {
compile (project(':libs:core')) {
transitive = false
}
compile (project(':libs:x-content')) {
Expand Down
2 changes: 1 addition & 1 deletion x-pack/plugin/sql/sql-shared-proto/build.gradle
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ description = 'Request and response objects shared by the cli, jdbc ' +
'and the Elasticsearch plugin'

dependencies {
compile (project(':libs:elasticsearch-core')) {
compile (project(':libs:core')) {
transitive = false
}
compile (project(':libs:x-content')) {
Expand Down