Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid sending duplicate remote failed shard requests #31313

Merged
merged 10 commits into from
Jun 18, 2018
Merged

Avoid sending duplicate remote failed shard requests #31313

merged 10 commits into from
Jun 18, 2018

Commits on Jun 14, 2018

  1. TEST: getCapturedRequestsAndClear should be atomic 

    We might lose messages between getCapturedRequestsAndClear calls. This
commit makes sure that both getCapturedRequestsAndClear and
getCapturedRequestsByTargetNodeAndClear are atomic.
    @dnhatn
    dnhatn committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    99562c0 View commit details
    Browse the repository at this point in the history

  2. Avoid sending duplicate remote failed shard requests 

    Today if a replica fails, we will send a shard failed request for each replication request to the master node until that primary receives the new cluster state. However, if a bulk requests are large and the master node is busy, we might overwhelm the cluster with shard failed requests.

This commit tries to minimize the shard failed requests in the above scenario by caching the ongoing requests.

This was discussed at https://discuss.elastic.co/t/half-dead-node-lead-to-cluster-hang/113658/25
    @dnhatn
    dnhatn committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    251d44c View commit details
    Browse the repository at this point in the history

  3. Merge branch 'master' into cache-remote-shards-failed

    @dnhatn
    dnhatn committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    71a2db4 View commit details
    Browse the repository at this point in the history

  4. Simplify report

    @dnhatn
    dnhatn committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    6a704c7 View commit details
    Browse the repository at this point in the history

  5. Remove identity map

    @dnhatn
    dnhatn committed Jun 14, 2018
    Configuration menu
    Copy the full SHA
    7601a13 View commit details
    Browse the repository at this point in the history

Commits on Jun 15, 2018

  1. Revert "TEST: getCapturedRequestsAndClear should be atomic" 

    This reverts commit 99562c0.
    @dnhatn
    dnhatn committed Jun 15, 2018
    Configuration menu
    Copy the full SHA
    19baf31 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into cache-remote-shards-failed

    @dnhatn
    dnhatn committed Jun 15, 2018
    Configuration menu
    Copy the full SHA
    dcdaba7 View commit details
    Browse the repository at this point in the history

Commits on Jun 18, 2018

  1. Address Yannick’s comments

    @dnhatn
    dnhatn committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    a102531 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into cache-remote-shards-failed

    @dnhatn
    dnhatn committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    56da910 View commit details
    Browse the repository at this point in the history

  3. Randomize primary term

    @dnhatn
    dnhatn committed Jun 18, 2018
    Configuration menu
    Copy the full SHA
    496a6bd View commit details
    Browse the repository at this point in the history