-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RFC: Test that example plugins build stand-alone #32235
Merged
Merged
Commits on Jul 20, 2018
-
RFC: Test that example plugins build stand-alone
The initial goal was to write a test to make sure that build-tools can be used by plugin authors outside of our build. Example projects seemed like a good fit rather than writing dummy ones just for the test. - Add an integration test based on testKit to build the example plugins like stand alone projects - the tests injects the snapshots repo right now - an alternative would be to inject the last release version to cause dependency resolution against that. It wouldn't be 100% realistic as we would build using old dependencies and current build-tools which never happens in practice, but it would result in fewer moving parts. - the snapshots does cover more ground at the cost of some confusion as these are delayed from the current build, so any new issues will introduced will surface in the next build only. - there are also some changes for making it easier to copy these examples, but it won't quite work yet, e.x. applying the plugin only works because of testKit. Applying the project like this won't work. It might work if we add a version number and publish it to the Gradle plugin portal. - testKit can have the gradle version configured, so it would be easy to add similar tests for different Gradle versions. - The tests are failing due to 2 reasons: - elasticsearch-nio is not published. I am looking to fix this. - `painless-whitelist` references `project(':modules:lang-painless')` so this isn't really an example that will work stand-alone. Not sure what we should do about this one? Not test it or publish the plugin jar ?
Configuration menu - View commit details
-
Copy full SHA for 5cb970a - Browse repository at this point
Copy the full SHA 5cb970aView commit details
Commits on Jul 21, 2018
-
Configuration menu - View commit details
-
Copy full SHA for fa25aee - Browse repository at this point
Copy the full SHA fa25aeeView commit details
Commits on Aug 7, 2018
-
Configuration menu - View commit details
-
Copy full SHA for b0213f4 - Browse repository at this point
Copy the full SHA b0213f4View commit details -
Configuration menu - View commit details
-
Copy full SHA for bca30ef - Browse repository at this point
Copy the full SHA bca30efView commit details -
Create a
publishNebulaPublicationToLocalTestRepository
taskWill publish everything that has publishing configured to a local repo
Configuration menu - View commit details
-
Copy full SHA for 1356199 - Browse repository at this point
Copy the full SHA 1356199View commit details -
Configuration menu - View commit details
-
Copy full SHA for db988ef - Browse repository at this point
Copy the full SHA db988efView commit details
Commits on Aug 10, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 34d73bc - Browse repository at this point
Copy the full SHA 34d73bcView commit details
Commits on Aug 15, 2018
-
Configuration menu - View commit details
-
Copy full SHA for cdb057b - Browse repository at this point
Copy the full SHA cdb057bView commit details
Commits on Aug 16, 2018
-
Configuration menu - View commit details
-
Copy full SHA for 4ef6a43 - Browse repository at this point
Copy the full SHA 4ef6a43View commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.