Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Test that example plugins build stand-alone #32235

Merged
merged 9 commits into from
Aug 17, 2018

Commits on Jul 20, 2018

  1. RFC: Test that example plugins build stand-alone

    The initial goal was to write a test to make sure that build-tools can
    be used by plugin authors outside of our build. Example projects seemed
    like a good fit rather than writing dummy ones just for the test.
    
    - Add an integration test based on testKit to build the example plugins
    like stand alone projects
    - the tests injects the snapshots repo right now
       - an alternative would be to inject the last release version to cause
         dependency resolution against that. It wouldn't be 100% realistic
         as we would build using old dependencies and current build-tools
         which never happens in practice, but it would result in fewer
         moving parts.
       - the snapshots does cover more ground at the cost of some confusion
         as these are delayed from the current build, so any new issues will
         introduced will surface in the next build only.
    - there are also some changes for making it easier to copy these
    examples, but it won't quite work yet, e.x. applying the plugin
    only works because of testKit. Applying the project like this won't work.
    It might work if we add a version number and publish it to the
    Gradle plugin portal.
    - testKit can have the gradle version configured, so it would be easy to
    add similar tests for different Gradle versions.
    - The tests are failing due to 2 reasons:
       - elasticsearch-nio is not published. I am looking to fix this.
       - `painless-whitelist` references `project(':modules:lang-painless')`
          so this isn't really an example that will work stand-alone.
          Not sure what we should do about this one? Not test it or publish
          the plugin jar ?
    alpar-t committed Jul 20, 2018
    Configuration menu
    Copy the full SHA
    5cb970a View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2018

  1. Configuration menu
    Copy the full SHA
    fa25aee View commit details
    Browse the repository at this point in the history

Commits on Aug 7, 2018

  1. Configuration menu
    Copy the full SHA
    b0213f4 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    bca30ef View commit details
    Browse the repository at this point in the history
  3. Create a publishNebulaPublicationToLocalTestRepository task

    Will publish everything that has publishing configured to a local repo
    alpar-t committed Aug 7, 2018
    Configuration menu
    Copy the full SHA
    1356199 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    db988ef View commit details
    Browse the repository at this point in the history

Commits on Aug 10, 2018

  1. pr review

    alpar-t committed Aug 10, 2018
    Configuration menu
    Copy the full SHA
    34d73bc View commit details
    Browse the repository at this point in the history

Commits on Aug 15, 2018

  1. useold syntax to apply plugin

    alpar-t committed Aug 15, 2018
    Configuration menu
    Copy the full SHA
    cdb057b View commit details
    Browse the repository at this point in the history

Commits on Aug 16, 2018

  1. PR review

    alpar-t committed Aug 16, 2018
    Configuration menu
    Copy the full SHA
    4ef6a43 View commit details
    Browse the repository at this point in the history