Number of utilities for writing gradle integration tests #32282
Conversation
These are collected from a number of open PRs and are required to improove existing and write more readable future tests. I am extracting them to their own PR hoping to be able to merge and use them sooner.
alpar-t
added
>test
|
Pinging @elastic/es-core-infra |
There was a problem hiding this comment.
These do seem useful to me but I'd prefer they go in when we use them for the first time just because it feels more in line with how we write software. But they do seem nice and if you need them in a few PRs I totally understand wanting them now so your in flight PRs are easier to review. I'm +1 on merging so long as you go back through them when you current crop of PRs is done and remove what you don't end up needing.
|
Thanks Nik! I agree with you about adding these when needed, they all came out of PRs where these were used and wished fro them to be there in others I was working on. I'll make sure there's no unused ones in the end. Their small pieces of functionality, and repeating them wouldn't be that bad, but I think it makes the test better, unfortunately that's exactly the context missing here. |
These are collected from a number of open PRs and are required to improove existing and write more readable future tests. I am extracting them to their own PR hoping to be able to merge and use them sooner.
* elastic/6.x: Tests: Fix XPack upgrade tests (#32352) Remove invalid entry from 6.3.2 release notes Number of utilities for writing gradle integration tests (#32282) Determine the minimum gradle version based on the wrapper (#32226) Enable FIPS JVM in CI (#32330) Build: Fix jarHell error I caused by last backport Build: Shadow x-pack:protocol into x-pack:plugin:core (#32240)
* ccr: Number of utilities for writing gradle integration tests (elastic#32282) Determine the minimum gradle version based on the wrapper (elastic#32226) Enable FIPS JVM in CI (elastic#32330) Build: Fix jarHell error I caused by last backport Use shadow plugin in ccr/qa Fix JarHell on X-Pack protocol
These are collected from a number of open PRs and are required to
improove existing and write more readable future tests.
I am extracting them to their own PR hoping to be able to merge and use
them sooner.