[Kerberos] Add authorization realms support to Kerberos realm #32392
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit allows Kerberos realm to delegate `User` creation to configured authorization realms. If no authorization realms are configured, then Kerberos realm uses native role mapper to resolve User.
bizybot
added
review
:Security/Authentication
|
Pinging @elastic/es-security |
tvernum
requested changes
Jul 30, 2018
This commit adds missing authorization settings in Kerberos realm settings.
|
Thanks, @tvernum. I have addressed your review comment. Please review when you get some time. |
jaymode
approved these changes
Jul 30, 2018
| if (delegatedRealms.hasDelegation()) { | ||
| delegatedRealms.resolve(username, ActionListener.wrap(result -> { | ||
| if (result.isAuthenticated() && userPrincipalNameToUserCache != null) { | ||
| userPrincipalNameToUserCache.put(username, result.getUser()); |
There was a problem hiding this comment.
I don't think we need to cache here. The delegated realm resolved the user and it should be caching it. The kerberos realm will never use the cache entry that we add
There was a problem hiding this comment.
Cool, I too did not want to add caching here but thought it would be consistent with others. I will remove it. Thank you.
| @@ -101,13 +107,20 @@ protected void assertSuccessAuthenticationResult(final User expectedUser, final | |||
| is(equalTo(KerberosAuthenticationToken.NEGOTIATE_AUTH_HEADER_PREFIX + outToken))); | |||
| } | |||
|
|
|||
|
|
|||
added 4 commits
July 31, 2018 10:59
Removed the caching in case delegated realms are used for user resolution.
|
@elasticmachine, test this please. |
albertzaharovits
approved these changes
Aug 2, 2018
colings86
added
>enhancement
and removed
:Security/Authentication
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows Kerberos realm to delegate
Userresolutionto configured authorization realms. If Kerberos realm is not configured
with any authorization realms then it uses the native role mapper to
resolve User.