Simplify the return type of FieldMapper#parse. #32654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jtibshirani
added
:Search Foundations/Mapping
|
Pinging @elastic/es-search-aggs |
jtibshirani
force-pushed
the
field-parsing
branch
from
b7035ff
to
19f0a06
Compare
cbuescher
approved these changes
Aug 27, 2018
There was a problem hiding this comment.
@jtibshirani makes sense to me, I took a quick look and only left one comment regarding changing of a javadoc comment. LGTM otherwise.
| @@ -268,7 +268,7 @@ public CopyTo copyTo() { | |||
| * update if dynamic mappings modified the mappings, or {@code null} if | |||
| * mappings were not modified. | |||
| */ | |||
| public Mapper parse(ParseContext context) throws IOException { | |||
| public void parse(ParseContext context) throws IOException { | |||
There was a problem hiding this comment.
I think it makes sense to also update the method comment according to the change.
There was a problem hiding this comment.
Oops, thanks! Will update.
jtibshirani
force-pushed
the
field-parsing
branch
from
19f0a06
to
970dcfa
Compare
jasontedor
added a commit
to jasontedor/elasticsearch
that referenced
this pull request
Sep 4, 2018
…e-default-distribution * elastic/master: (213 commits) ML: Fix build after HLRC change Fix inner hits retrieval when stored fields are disabled (_none_) (elastic#33018) SQL: Show/desc commands now support table ids (elastic#33363) Mute testValidateFollowingIndexSettings HLRC: Add delete by query API (elastic#32782) [ML] The sort field on get records should default to the record_score (elastic#33358) [ML] Minor improvements to categorization Grok pattern creation (elastic#33353) [DOCS] fix a couple of typos (elastic#33356) Disable assemble task instead of removing it (elastic#33348) Simplify the return type of FieldMapper#parse. (elastic#32654) [ML] Delete forecast API (elastic#31134) (elastic#33218) Introduce private settings (elastic#33327) [Docs] Add search timeout caveats (elastic#33354) TESTS: Fix Race Condition in Temp Path Creation (elastic#33352) Fix from_range in search_after in changes snapshot (elastic#33335) TESTS+DISTR.: Fix testIndexCheckOnStartup Flake (elastic#33349) Null completion field should not throw IAE (elastic#33268) Adds code to help with IndicesRequestCacheIT failures (elastic#33313) Prevent NPE parsing the stop datafeed request. (elastic#33347) HLRC: Add ML get overall buckets API (elastic#33297) ...
jtibshirani
added a commit
that referenced
this pull request
Sep 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No implementation of this method returned a non-null value. It looks like the dynamic creation of field mappers is fully handled by
DocumentParser#parseDynamicValue.