Move connection listener to ConnectionManager #32956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Tim-Brooks
added
>non-issue
review
:Distributed/Network
|
Pinging @elastic/es-core-infra |
|
Jenkins run gradle build tests |
Tim-Brooks
added a commit
to Tim-Brooks/elasticsearch
that referenced
this pull request
Aug 20, 2018
This is a follow-up to elastic#32956. That commit incorrectly used assertBusy which led to a possible race in the test. This commit fixes it.
jasontedor
added a commit
that referenced
this pull request
Aug 20, 2018
* master: Generalize remote license checker (#32971) Trim translog when safe commit advanced (#32967) Fix an inaccuracy in the dynamic templates documentation. (#32890) Logging: Use settings when building daemon threads (#32751) All Translog inner closes should happen after tragedy exception is set (#32674) HLREST: AwaitsFix ML Test Pass DiscoveryNode to initiateChannel (#32958) Add mzn and dz to unsupported locales (#32957) Use settings from the context in BootstrapChecks (#32908) Update docs for node specifications (#30468) HLRC: Forbid all Elasticsearch logging infra (#32784) Only configure publishing if it's applied externally (#32351) Fixes libs:dissect when in eclipse Protect ScriptedMetricIT test cases against failures on 0-doc shards (#32959) (#32968) [Kerberos] Add documentation for Kerberos realm (#32662) Watcher: Properly find next valid date in cron expressions (#32734) Fix some small issues in the getting started docs (#30346) Set forbidden APIs target compatibility to compiler java version (#32935) Move connection listener to ConnectionManager (#32956)
Tim-Brooks
added a commit
that referenced
this pull request
Aug 20, 2018
This is a follow-up to #32956. That commit incorrectly used assertBusy which led to a possible race in the test. This commit fixes it.
Tim-Brooks
added a commit
that referenced
this pull request
Aug 21, 2018
This is a follow-up to #32956. That commit incorrectly used assertBusy which led to a possible race in the test. This commit fixes it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a followup to #31886. After that commit the
TransportConnectionListenerhad to be propogated to both theTransportand theConnectionManager. This commit moves that listenerto completely live in the
ConnectionManager. The request and responserelated methods are moved to a
TransportMessageListener. That listenercontinues to live in the
Transportclass.