Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NETWORKING: Make RemoteClusterConn. Lazy Resolve DNS (#32764) #32976

Merged
merged 1 commit into from
Aug 19, 2018

Commits on Aug 19, 2018

  1. NETWORKING: Make RemoteClusterConn. Lazy Resolve DNS (elastic#32764)

    * Lazy resolve DNS (i.e. `String` to `DiscoveryNode`) to not run into indefinitely caching lookup issues (provided the JVM dns cache is configured correctly as explained in https://www.elastic.co/guide/en/elasticsearch/reference/6.3/networkaddress-cache-ttl.html)
       * Changed `InetAddress` type to `String` for that higher up the stack
       * Passed down `Supplier<DiscoveryNode>` instead of outright `DiscoveryNode` from `RemoteClusterAware#buildRemoteClustersSeeds` on to lazy resolve DNS when the `DiscoveryNode` is actually used (could've also passed down the value of `clusterName = REMOTE_CLUSTERS_SEEDS.getNamespace(concreteSetting)` together with the `List<String>` of hosts, but this route seemed to introduce less duplication and resulted in a significantly smaller changeset).
    * Closes elastic#28858
    original-brownbear committed Aug 19, 2018
    Configuration menu
    Copy the full SHA
    3d4cad6 View commit details
    Browse the repository at this point in the history