Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CCR] Delay auto follow license check #33557

Merged
merged 2 commits into from
Sep 10, 2018
Merged

[CCR] Delay auto follow license check #33557

merged 2 commits into from
Sep 10, 2018

Conversation

martijnvg
Copy link
Member

so that we're sure that there are auto follow patterns configured

Otherwise we log many warnings in case someone is running with basic or gold
license and has not used the ccr feature:

[elasticsearch] [2018-09-10T09:58:12,633][INFO ][o.e.n.Node               ] [node-0] started
[elasticsearch] [2018-09-10T09:58:12,704][INFO ][o.e.g.GatewayService     ] [node-0] recovered [0] indices into cluster_state
[elasticsearch] [2018-09-10T09:58:12,790][INFO ][o.e.c.m.MetaDataIndexTemplateService] [node-0] adding template [.watches] for index patterns [.watches*]
[elasticsearch] [2018-09-10T09:58:12,847][INFO ][o.e.c.m.MetaDataIndexTemplateService] [node-0] adding template [.watch-history-9] for index patterns [.watcher-history-9*]
[elasticsearch] [2018-09-10T09:58:12,877][INFO ][o.e.c.m.MetaDataIndexTemplateService] [node-0] adding template [.triggered_watches] for index patterns [.triggered_watches*]
[elasticsearch] [2018-09-10T09:58:12,922][INFO ][o.e.c.m.MetaDataIndexTemplateService] [node-0] adding template [.monitoring-logstash] for index patterns [.monitoring-logstash-6-*]
[elasticsearch] [2018-09-10T09:58:12,969][INFO ][o.e.c.m.MetaDataIndexTemplateService] [node-0] adding template [.monitoring-es] for index patterns [.monitoring-es-6-*]
[elasticsearch] [2018-09-10T09:58:13,007][INFO ][o.e.c.m.MetaDataIndexTemplateService] [node-0] adding template [.monitoring-alerts] for index patterns [.monitoring-alerts-6]
[elasticsearch] [2018-09-10T09:58:13,049][INFO ][o.e.c.m.MetaDataIndexTemplateService] [node-0] adding template [.monitoring-beats] for index patterns [.monitoring-beats-6-*]
[elasticsearch] [2018-09-10T09:58:13,089][INFO ][o.e.c.m.MetaDataIndexTemplateService] [node-0] adding template [.monitoring-kibana] for index patterns [.monitoring-kibana-6-*]
[elasticsearch] [2018-09-10T09:58:13,191][INFO ][o.e.l.LicenseService     ] [node-0] license [26b3e83d-2d85-4a69-95a4-fb8c554764a5] mode [basic] - valid
[elasticsearch] [2018-09-10T09:58:15,111][WARN ][o.e.x.c.a.AutoFollowCoordinator] [node-0] skipping auto-follower coordination
[elasticsearch] org.elasticsearch.ElasticsearchSecurityException: current license is non-compliant for [ccr]
[elasticsearch]         at org.elasticsearch.license.LicenseUtils.newComplianceException(LicenseUtils.java:27) ~[x-pack-core-7.0.0-alpha1-SNAPSHOT.jar:7.0.0-alpha1-SNAPSHOT]
[elasticsearch]         at org.elasticsearch.xpack.ccr.action.AutoFollowCoordinator.doAutoFollow(AutoFollowCoordinator.java:75) [x-pack-ccr-7.0.0-alpha1-SNAPSHOT.jar:7.0.0-alpha1-SNAPSHOT]
[elasticsearch]         at org.elasticsearch.threadpool.ThreadPool$LoggingRunnable.run(ThreadPool.java:445) [elasticsearch-7.0.0-alpha1-SNAPSHOT.jar:7.0.0-alpha1-SNAPSHOT]
[elasticsearch]         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:514) [?:?]
[elasticsearch]         at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
[elasticsearch]         at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) [?:?]
[elasticsearch]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135) [?:?]
[elasticsearch]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
[elasticsearch]         at java.lang.Thread.run(Thread.java:844) [?:?]
[elasticsearch] [2018-09-10T09:58:17,619][WARN ][o.e.x.c.a.AutoFollowCoordinator] [node-0] skipping auto-follower coordination
[elasticsearch] org.elasticsearch.ElasticsearchSecurityException: current license is non-compliant for [ccr]
[elasticsearch]         at org.elasticsearch.license.LicenseUtils.newComplianceException(LicenseUtils.java:27) ~[x-pack-core-7.0.0-alpha1-SNAPSHOT.jar:7.0.0-alpha1-SNAPSHOT]
[elasticsearch]         at org.elasticsearch.xpack.ccr.action.AutoFollowCoordinator.doAutoFollow(AutoFollowCoordinator.java:75) [x-pack-ccr-7.0.0-alpha1-SNAPSHOT.jar:7.0.0-alpha1-SNAPSHOT]
[elasticsearch]         at org.elasticsearch.threadpool.ThreadPool$LoggingRunnable.run(ThreadPool.java:445) [elasticsearch-7.0.0-alpha1-SNAPSHOT.jar:7.0.0-alpha1-SNAPSHOT]
[elasticsearch]         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:514) [?:?]
[elasticsearch]         at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
[elasticsearch]         at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) [?:?]
[elasticsearch]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135) [?:?]
[elasticsearch]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
[elasticsearch]         at java.lang.Thread.run(Thread.java:844) [?:?]
[elasticsearch] [2018-09-10T09:58:20,121][WARN ][o.e.x.c.a.AutoFollowCoordinator] [node-0] skipping auto-follower coordination
[elasticsearch] org.elasticsearch.ElasticsearchSecurityException: current license is non-compliant for [ccr]
[elasticsearch]         at org.elasticsearch.license.LicenseUtils.newComplianceException(LicenseUtils.java:27) ~[x-pack-core-7.0.0-alpha1-SNAPSHOT.jar:7.0.0-alpha1-SNAPSHOT]
[elasticsearch]         at org.elasticsearch.xpack.ccr.action.AutoFollowCoordinator.doAutoFollow(AutoFollowCoordinator.java:75) [x-pack-ccr-7.0.0-alpha1-SNAPSHOT.jar:7.0.0-alpha1-SNAPSHOT]
[elasticsearch]         at org.elasticsearch.threadpool.ThreadPool$LoggingRunnable.run(ThreadPool.java:445) [elasticsearch-7.0.0-alpha1-SNAPSHOT.jar:7.0.0-alpha1-SNAPSHOT]
[elasticsearch]         at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:514) [?:?]
[elasticsearch]         at java.util.concurrent.FutureTask.run(FutureTask.java:264) [?:?]
[elasticsearch]         at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:304) [?:?]
[elasticsearch]         at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1135) [?:?]
[elasticsearch]         at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:635) [?:?]
[elasticsearch]         at java.lang.Thread.run(Thread.java:844) [?:?]

@martijnvg
[CCR] Delay auto follow license check
de4b8b9 
so that we're sure that there are auto follow patterns configured

Otherwise we log a warning in case someone is running with basic or gold
license and has not used the ccr feature.
@martijnvg martijnvg added >non-issue review v7.0.0 :Distributed/CCR Issues around the Cross Cluster State Replication features v6.5.0 labels Sep 10, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-distributed

@martijnvg
fixed test to have an auto follow pattern,
be6d49f 
so that we do log a warning and validate that
jasontedor
jasontedor approved these changes Sep 10, 2018
View reviewed changes
Copy link
Member

@jasontedor jasontedor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@martijnvg martijnvg merged commit 8eebca3 into elastic:master Sep 10, 2018
martijnvg added a commit that referenced this pull request Sep 10, 2018
@martijnvg
[CCR] Delay auto follow license check (#33557)
eee0086 
* [CCR] Delay auto follow license check
so that we're sure that there are auto follow patterns configured

Otherwise we log a warning in case someone is running with basic or gold
license and has not used the ccr feature.
jasontedor added a commit to jasontedor/elasticsearch that referenced this pull request Sep 11, 2018
@jasontedor
Merge branch 'master' into upgrade-remote-cluster-settings
f82e74d 
* master:
  Add full cluster restart base class (elastic#33577)
  Validate list values for settings (elastic#33503)
  Copy and validatie soft-deletes setting on resize (elastic#33517)
  Test: Fix package name
  SQL: Fix result column names for arithmetic functions (elastic#33500)
  Upgrade to latest Lucene snapshot (elastic#33505)
  Enable not wiping cluster settings after REST test (elastic#33575)
  MINOR: Remove Dead Code in SearchScript (elastic#33569)
  [Test] Remove duplicate method in TestShardRouting (elastic#32815)
  mute test on windows
  Update beats template to include apm-server metrics (elastic#33286)
  Fix typos (elastic#33499)
  [CCR] Delay auto follow license check (elastic#33557)
  [CCR] Add create_follow_index privilege (elastic#33559)
  Strengthen FilterRoutingTests (elastic#33149)
  Correctly handle PKCS#11 tokens for system keystore (elastic#33460)
  Remove some duplicate request conversion methods. (elastic#33538)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasontedor jasontedor jasontedor approved these changes

Assignees
No one assigned
Labels
:Distributed/CCR Issues around the Cross Cluster State Replication features >non-issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@martijnvg @elasticmachine @jasontedor