Add a limit for graph phrase query expansion #34061
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Backport of elastic#34031 for 5.6.
jimczi
added
>bug
:Search/Search
|
Pinging @elastic/es-search-aggs |
… expansion of graph phrase query (defaults to unlimited)
jimczi
commented
Oct 19, 2018
There was a problem hiding this comment.
@colings86 , as discussed with Jason yesterday I added a JVM option named es.query.apply_graph_phrase_limit to activate the limit in this version. By default it is deactivated and the only valid value for the JVM option is true.
colings86
reviewed
Oct 19, 2018
core/src/main/java/org/apache/lucene/queryparser/classic/MapperQueryParser.java
Show resolved
Hide resolved
colings86
approved these changes
Oct 19, 2018
| @@ -889,11 +888,12 @@ protected SpanQuery analyzeGraphPhrase(TokenStream source, String field, int phr | |||
| * The JVM option can only be set to <code>true</code> (false is the default value), any other value | |||
| * will throw an {@link IllegalArgumentException}. | |||
| */ | |||
| // public for tests | |||
There was a problem hiding this comment.
I think this isn't just public for tests now that SearchModule calls it?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #34031 for 5.6.