-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
XPack/HLRC request/response compatibility tests #34547
XPack/HLRC request/response compatibility tests #34547
Conversation
Pinging @elastic/es-core-infra |
A while ago I started hacking together a thing in |
...esponse-tests/src/test/java/org/elasticsearch/protocol/xpack/license/LicenseStatusTests.java
Outdated
Show resolved
Hide resolved
…l_cleanup_2' into hlrc_xprotocol_response_tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm happy with this! Do you want to drop the WIP tag?
…' into hlrc_xprotocol_response_tests
@nik9000 this PR at the latest stage as far as all preliminary PRs are merged, could you pls have another look into it ? |
...in/core/src/test/java/org/elasticsearch/protocol/AbstractHlrcStreamableXContentTestCase.java
Outdated
Show resolved
Hide resolved
Wonderful! |
…col_response_tests
Relates elastic#34451 , backports elastic#34547 (cherry picked from commit 28bb1a3)
Actually we don't have any validation for the compatibility of XPack requests/responses and HLRC implementation of those requests/responses.
This PR is to fill this gap
note: while we have
xpack/protocol
these tests could not be run due to jar hell.Relates to #34451