-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
HLRC: Delete role API #34620
HLRC: Delete role API #34620
Conversation
Pinging @elastic/es-security |
Pinging @elastic/es-core-infra |
@elasticmachine retest this please |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly nits and missing one test. Easy peasy!
} | ||
|
||
@Override | ||
public XContentBuilder toXContent(XContentBuilder builder, Params params) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this is not needed, an the class does not have to be a ToXContentObject either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 86cf213
@@ -0,0 +1,46 @@ | |||
[[java-rest-high-security-delete-role]] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a nicer way to do the docs now. See #34203
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in 27590cf
/** | ||
* Response for a role being deleted from the native realm | ||
*/ | ||
public final class DeleteRoleResponse { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have some better tests to test the responses now too. Check out https://github.com/elastic/elasticsearch/blob/master/client/rest-high-level/src/test/java/org/elasticsearch/client/watcher/ActivateWatchResponseTests.java
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed in
c041014
Adds the "Delete role" API to the high-level REST client.
Adds the "Delete role" API to the high-level REST client.
Adds the "Delete role" API to the high-level REST client.