Fix LineLength Check Suppressions: index.mapper #35087
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimirdolzhenko
added
>non-issue
:Core/Infra/Core
|
Pinging @elastic/es-core-infra |
33 tasks
nik9000
approved these changes
Oct 30, 2018
| assertNotNull(update); | ||
| // original mapping not modified | ||
| assertEquals(mapping, serialize(mapper)); | ||
| // but we have an update | ||
| assertEquals(Strings.toString(XContentFactory.jsonBuilder().startObject().startObject("type").startObject("properties") | ||
| .startObject("foo").startObject("properties").startObject("bar").startObject("properties").startObject("baz").field("type", "text") | ||
| .startObject("fields").startObject("keyword").field("type", "keyword").field("ignore_above", 256).endObject() | ||
| .startObject("foo").startObject("properties").startObject("bar").startObject("properties").startObject("baz") |
There was a problem hiding this comment.
I tend to try an indent these manually so they look a little more like json. Not that this is required, but it does help when they get big like this.
There was a problem hiding this comment.
But this one is actually pretty huge. I don't think it'd fit!
| .startObject() | ||
| .field("field", "value") | ||
| .startArray("nested1") | ||
| .startObject().field("field1", "1").startArray("nested2").startObject().field("field2", "2").endObject().startObject().field("field2", "3").endObject().endArray().endObject() | ||
| .startObject().field("field1", "4").startArray("nested2").startObject().field("field2", "5").endObject().startObject().field("field2", "6").endObject().endArray().endObject() | ||
| .startObject().field("field1", "1").startArray("nested2") |
| .endObject() | ||
| .endObject()); | ||
| String mapping = Strings.toString(XContentFactory.jsonBuilder() | ||
| .startObject() |
vladimirdolzhenko
added a commit
to vladimirdolzhenko/elasticsearch
that referenced
this pull request
Oct 31, 2018
Relates elastic#34884, backport of elastic#35087 (cherry picked from commit be75b40)
vladimirdolzhenko
added a commit
that referenced
this pull request
Oct 31, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix linelength suppressions in index.mapper
Relates #34884