-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix PrimaryAllocationIT#testForceStaleReplicaToBePromotedToPrimary #35728
Merged
vladimirdolzhenko
merged 4 commits into
elastic:master
from
vladimirdolzhenko:fix/35497
Nov 20, 2018
Merged
Fix PrimaryAllocationIT#testForceStaleReplicaToBePromotedToPrimary #35728
vladimirdolzhenko
merged 4 commits into
elastic:master
from
vladimirdolzhenko:fix/35497
Nov 20, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
grab in-sync set of the 1st cluster state change after reroute execution Closes 35497
vladimirdolzhenko
added
>test
Issues or PRs that are addressing/adding tests
:Distributed/Recovery
Anything around constructing a new shard, either from a local or a remote source.
v7.0.0
v6.5.0
v6.6.0
labels
Nov 20, 2018
Pinging @elastic/es-distributed |
DaveCTurner
reviewed
Nov 20, 2018
server/src/test/java/org/elasticsearch/cluster/routing/PrimaryAllocationIT.java
Show resolved
Hide resolved
DaveCTurner
reviewed
Nov 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Asked for a bit more logging just in case it fails again.
server/src/test/java/org/elasticsearch/cluster/routing/PrimaryAllocationIT.java
Outdated
Show resolved
Hide resolved
server/src/test/java/org/elasticsearch/cluster/routing/PrimaryAllocationIT.java
Show resolved
Hide resolved
DaveCTurner
approved these changes
Nov 20, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thanks @DaveCTurner |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
:Distributed/Recovery
Anything around constructing a new shard, either from a local or a remote source.
>test
Issues or PRs that are addressing/adding tests
v6.6.0
v7.0.0-beta1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Failure described in #35497 could be reproduced under load or just adding some delay in between reroute command execution and getting cluster state (allocation ids) - in that case recovery already passed and allocation ids contain actual node id rather expected allocation id right after command execution.
The fix is to grab in-sync set of the 1st cluster state change after reroute execution from
ClusterService
of the node.Closes #35497