Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken links in painless docs #36170

Merged
merged 2 commits into from
Dec 3, 2018
Merged

Fix broken links in painless docs #36170

merged 2 commits into from
Dec 3, 2018

Conversation

romseygeek
Copy link
Contributor

This fixes two broken links in painless-similarity-context.asciidoc

@romseygeek romseygeek added >bug >docs General docs changes :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache v7.0.0 v6.6.0 labels Dec 3, 2018
@romseygeek romseygeek self-assigned this Dec 3, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@lcawl
Copy link
Contributor

lcawl commented Dec 3, 2018 •
edited
Loading

The second URL doesn't work for me. Is it supposed to be a link to https://www.elastic.co/guide/en/elasticsearch/painless/master/painless-weight-context.html?
If so, you need to use {painless} instead of {ref} per https://github.com/elastic/docs/blob/master/shared/attributes.asciidoc

@romseygeek
Copy link
Contributor Author

Thanks @lcawl, I pushed a fix

lcawl
lcawl approved these changes Dec 3, 2018
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@romseygeek romseygeek merged commit 19b936d into elastic:master Dec 3, 2018
@romseygeek romseygeek deleted the fix-doc-links branch December 3, 2018 18:25
romseygeek added a commit that referenced this pull request Dec 3, 2018
@romseygeek
Fix broken links in painless docs (#36170)
2761016
@lcawl
Copy link
Contributor

lcawl commented Dec 3, 2018 •
edited
Loading

Alternatively, if those pages are both in the same book, you could do <<painless-weight-context>>

@lcawl
Copy link
Contributor

lcawl commented Dec 4, 2018

There ended up being a third broken link on this page, which I fixed via 05d52b2

@romseygeek
Copy link
Contributor Author

Thanks @lcawl !

spinscale pushed a commit that referenced this pull request Dec 4, 2018
@romseygeek @spinscale
Fix broken links in painless docs (#36170)
c15c3bb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl approved these changes

@karenzone karenzone Awaiting requested review from karenzone

Assignees

@romseygeek romseygeek

Labels
>bug :Core/Infra/Scripting Scripting abstractions, Painless, and Mustache >docs General docs changes v6.6.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@romseygeek @elasticmachine @lcawl @colings86