Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Deprecate X-Pack centric ML endpoints #36315

Merged

Conversation

droberts195
Copy link
Contributor

This commit is part of our plan to deprecate and
ultimately remove the use of _xpack in the REST APIs.

Relates #35958

This commit is part of our plan to deprecate and
ultimately remove the use of _xpack in the REST APIs.

Relates elastic#35958
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ml-core

@droberts195
Copy link
Contributor Author

The first commit on this PR contains the mechanical changes.

I fully expect that further more subtle changes will be required to get this fully working, but I wanted to get that first commit onto GitHub to reduce the risk of losing it.

Copy link
Member

@davidkyle davidkyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -0,0 +1,11 @@
{
"ml.info": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a new file rather than a rename

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see the file is deleted later

@droberts195
Copy link
Contributor Author

#36373 needs to be merged before the rolling upgrade tests will pass.

droberts195 added a commit that referenced this pull request Dec 7, 2018
In #36315 ML's _xpack/ml endpoints are deprecated, with the
recommended form becoming _ml.  This change allows use of the
new form in 6.x to facilitate operation of a mixed version
6.last/7.x cluster without suffering from deprecation warnings.

The new endpoints remain undocumented in 6.x but are documented
in the 7.0 PR #36315.
@droberts195
Copy link
Contributor Author

run gradle build tests 2

@droberts195 droberts195 merged commit 9e8cfbb into elastic:master Dec 7, 2018
@droberts195 droberts195 deleted the deprecate_xpack_in_ml_rest_endpoints branch December 7, 2018 20:34
@droberts195
Copy link
Contributor Author

I opened elastic/kibana#26876 to adjust the UI to use the new endpoints.

Also @dolaru you may want to adjust the master branch of the QA framework to use _ml instead of _xpack/ml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants