Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix line length for node and remove suppression. #37454

Merged
merged 1 commit into from
Jan 15, 2019
Merged

Fix line length for node and remove suppression. #37454

merged 1 commit into from
Jan 15, 2019

Conversation

dliappis
Copy link
Contributor

Relates #34884

@dliappis dliappis added the :Core/Infra/Core Core issues without another label label Jan 15, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

@dakrone dakrone mentioned this pull request Jan 15, 2019
Closed
33 tasks
danielmitterdorfer
danielmitterdorfer approved these changes Jan 15, 2019
View reviewed changes
Copy link
Member

@danielmitterdorfer danielmitterdorfer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dliappis
Copy link
Contributor Author

jenkins run the default distro tests

@dliappis
Copy link
Contributor Author

jenkins run the gradle build tests 1

@dliappis dliappis merged commit 6379349 into elastic:master Jan 15, 2019
@dliappis dliappis deleted the line-length-node branch January 15, 2019 17:57
dliappis added a commit that referenced this pull request Jan 15, 2019
@dliappis
Fix line length for node and remove suppresion (#37454)
0c0e7ca 
Relates #34884
@dliappis
Copy link
Contributor Author

Backported to 6.x -> 0c0e7ca

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danielmitterdorfer danielmitterdorfer danielmitterdorfer approved these changes

Assignees
No one assigned
Labels
:Core/Infra/Core Core issues without another label >non-issue v6.7.0 v7.0.0-beta1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dliappis @elasticmachine @danielmitterdorfer @colings86