SQL: Lowercase es data type (mapping) returned from SQL Commands #37531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To follow the ES convention, convert the es data type, returned as column `mapping` from SQL Commands, to lowercase. Fixes: elastic#37521
|
Pinging @elastic/es-search |
|
/cc @bpintea Please check if this affects ODBC. |
|
It doesn't, LGTM. |
|
Should we backport to earlier versions? |
|
run the gradle build tests 1 |
2 similar comments
|
run the gradle build tests 1 |
|
run the gradle build tests 1 |
matriv
added a commit
that referenced
this pull request
Jan 16, 2019
) To follow the ES convention, convert the es data type, returned as column `mapping` from SQL Commands, to lowercase. Fixes: #37521
|
Backported to |
cshtdd
added a commit
to cshtdd/elasticsearch
that referenced
this pull request
Jan 16, 2019
* master: SQL: Lowercase the datatypes in validation error msgs (elastic#37524) DedicatedClusterSnapshotRestoreIT to Zen2 (elastic#37489) SQL: Lowercase es data type (mapping) returned from SQL Commands (elastic#37531) Remove SYS CATALOGS leftover SQL: Describe aliases as views (elastic#37496)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To follow the ES convention, convert the es data type, returned as
column
mappingfrom SQL Commands, to lowercase.Fixes: #37521