Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate requests that have an unconsumed body #37534

Merged

Conversation

jasontedor
Copy link
Member

@jasontedor jasontedor commented Jan 16, 2019

This commit deprecates some leniency from REST handling where we move to deprecate all requests that have a body where the body is not used during the course of handling the request. For example,

DELETE /index
{
  "query" : {
    "term" :  {
      "field" : "value"
    }
  }
}

is now deprecated.

Relates #37504

This commit removes some leniency from REST handling where we move to
reject all requests that have a body where the body is not used during
the course of handling the request. For example,

DELETE /index
{
  "query" : {
    "term" :  {
      "field" : "value"
    }
  }
}

is now rejected.
@jasontedor jasontedor added >non-issue :Core/Infra/REST API REST infrastructure and utilities v6.7.0 labels Jan 16, 2019
@elasticmachine
Copy link
Collaborator

Pinging @elastic/es-core-infra

Copy link
Member

@martijnvg martijnvg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jasontedor jasontedor changed the title Reject all requests that have an unconsumed body Deprecate all requests that have an unconsumed body Jan 16, 2019
@jasontedor
Copy link
Member Author

@elasticmachine run gradle build tests 1

@jasontedor jasontedor merged commit 3765cb9 into elastic:6.x Jan 16, 2019
@jasontedor jasontedor deleted the reject-requests-with-an-unconsumed-body-6.x branch January 16, 2019 19:29
@jasontedor jasontedor changed the title Deprecate all requests that have an unconsumed body Deprecate requests that have an unconsumed body Jan 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:Core/Infra/REST API REST infrastructure and utilities >deprecation v6.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants