Enhancements to IndicesQueryCache. (#39099) #39626
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adds the following:
in which
IndicesQueryCache#onClose
andIndicesService.indicesRefCount#decRef
are called.IndicesQueryCache.stats2
a synchronized map. All writes to it arealready protected by the lock of the Lucene cache, but the final read from
an assertion in
IndicesQueryCache#close()
was not so this change shouldavoid any potential visibility issues.
toString
s to make debugging easier.Relates #37117