-
Notifications
You must be signed in to change notification settings - Fork 24.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve build configuration time #41392
Merged
mark-vieira
merged 44 commits into
elastic:master
from
mark-vieira:global-info-refactor
May 24, 2019
Merged
Changes from all commits
Commits
Show all changes
44 commits
Select commit
Hold shift + click to select a range
e23d207
work in progress
mark-vieira fd193d3
wip
mark-vieira 0643838
more wip
mark-vieira 5512fff
tweaks
mark-vieira 58882ed
Merge remote-tracking branch 'mark-vieira/global-info-refactor' into …
mark-vieira fdbbb38
Convert BuildPlugin to static Groovy
mark-vieira 90e4d40
Remove unnecessary Fips configuration
mark-vieira 8b4c313
Merge remote-tracking branch 'origin/master' into global-info-refactor
mark-vieira a8fa5ca
Merge remote-tracking branch 'origin/master' into global-info-refactor
mark-vieira 323f2e7
Remove usage of Java 11 API to maintain Java 8 compatibility
mark-vieira 1341666
Checkstyle
mark-vieira 3050799
Correctly configure target and source compatibility
mark-vieira 202541a
Fixes for fipsJvm-specific config
mark-vieira f403411
Fix reference to BasePluginConvention
mark-vieira fdeb65f
Fix publishing plugin configuration
mark-vieira e0cdc2a
Build plugin and global info plugin are coupled, let's enforce that
mark-vieira 99f2510
We need to apply it here as well, you know, ordering and stuff
mark-vieira b169755
Make sure compile conventions are applied to QA projects
mark-vieira e3c4be6
Just get compilation to work
mark-vieira 60a7d97
Datastructure is no longer a Map
mark-vieira 041fa32
Fix java home location
mark-vieira 475054a
Merge remote-tracking branch 'origin/master' into global-info-refactor
mark-vieira 35f0bd0
Merge remote-tracking branch 'origin/master' into global-info-refactor
mark-vieira 20064e3
Fix issue with UP-TO-DATE reporting
mark-vieira 26cc00d
Unused import
mark-vieira e3cb50a
Ensure fips jvm metadata is tracked as an output
mark-vieira f8096db
Merge remote-tracking branch 'origin/master' into global-info-refactor
mark-vieira 6255824
Sort out issue with cluster start/stop ordering.
mark-vieira db86526
Read cluster settings at execution time
mark-vieira acec279
Remove unnecessarily usages of runJavaAsScript()
mark-vieira b30c87b
Merge remote-tracking branch 'origin/master' into global-info-refactor
mark-vieira 3de9468
This should be immutable
mark-vieira 70e5148
Remove unnecessary newline
mark-vieira 9664bf5
Merge remote-tracking branch 'origin/master' into global-info-refactor
mark-vieira 3907284
Merge remote-tracking branch 'origin/master' into global-info-refactor
mark-vieira 69952e2
Deal with fallout from merging #41989
mark-vieira aa4bc82
Merge remote-tracking branch 'origin/master' into global-info-refactor
mark-vieira f7929ae
Address review feedback
mark-vieira 1104f52
Keep java 8 compatibility for build-tools
mark-vieira 1eafd8c
Reorder class members
mark-vieira c9299c1
Remove intermediary variable
mark-vieira 8cc01e4
Check for existence of java home directories
mark-vieira 19d6479
Merge remote-tracking branch 'origin/master' into global-info-refactor
mark-vieira 3290640
Merge remote-tracking branch 'origin/master' into global-info-refactor
mark-vieira File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
737 changes: 270 additions & 467 deletions
737
buildSrc/src/main/groovy/org/elasticsearch/gradle/BuildPlugin.groovy
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
File renamed without changes.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why wouldn't the config be necessary? Maybe worth adding a comment to explain.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There's not point in doing substitutions on internal configurations that cannot be resolved. I think this is a bit moot anyway since all this is going to get ripped out as part of #42093.