add EdgeTree support for lines/multilines #43949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The main change here is that edge-trees originally checked whether the queried extent could be contained within its shape. Since line-strings have no inner boundaries, this check is not useful, the line crosses check + extent-check-bounds is sufficient.
talevy
added
WIP
:Analytics/Geo
|
Pinging @elastic/es-analytics-geo |
imotov
reviewed
Jul 8, 2019
There was a problem hiding this comment.
Looks good to me. The name closed confused me a bit, since we are using it in the context of shapes for a slightly different purpose. I think in this context we want to indicate dimension. closed == true means we are dealing with area or 2 dimensional shapes and closed == false means that we are dealing with 1 dimensional shapes.
server/src/main/java/org/elasticsearch/common/geo/EdgeTreeReader.java
Outdated
Show resolved
Hide resolved
better define the difference between edge-trees representing polygons vs. line-strings. Polygons have non-zero areas. Also added tests for shapeType and closed line-strings.
|
test this please |
talevy
added a commit
that referenced
this pull request
Sep 20, 2019
The main change here is that edge-trees originally checked whether the queried extent could be contained within its shape. Since line-strings have no inner boundaries, this check is not useful, the line crosses check + extent-check-bounds is sufficient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main change here is that edge-trees originally
checked whether the queried extent could be contained
within its shape. Since line-strings have no inner boundaries,
this check is not useful, the line crosses check + extent-check-bounds
is sufficient.